Skip to content

Fix actions #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
matsui528 opened this issue May 21, 2025 · 3 comments · May be fixed by #46
Open

Fix actions #45

matsui528 opened this issue May 21, 2025 · 3 comments · May be fixed by #46
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@matsui528
Copy link
Owner

After #42, the actions fail. I'd like to fix the issue. Ref #44

  • According to the static type checking by mypy, the current code has issues in many parts. I want to fix these.
  • The tests related to faiss are failing. I want to fix this as well.

Any PRs are welcome!
@matsui528 matsui528 added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels May 21, 2025
@asukaminato0721 asukaminato0721 linked a pull request May 22, 2025 that will close this issue
Open
@asukaminato0721
Copy link
Contributor

but the test seems will fail, I don't know the reason...

@matsui528
Copy link
Owner Author

Let's break down the problem. In the first PR, please

  • Comment out all anaonda-related lines
  • Solve the mypy-related errors

We need to be sure that CI works correctly at this stage.

Then, we can make another PR that solves anaconda-related problems.

@asukaminato0721
Copy link
Contributor

it works actually, only the test failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

try fix asukaminato0721/nanopq
2 participants
@matsui528 @asukaminato0721