Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: verification endpoint alignment with etherscan #367

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+115 −14

fix: resove empty constructor arguments properly

e3f982f
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

fix: verification endpoint alignment with etherscan #367

fix: resove empty constructor arguments properly
e3f982f
Select commit
Loading
Failed to load commit list.
GitHub Actions / API E2E Test Results failed Jan 16, 2025 in 0s

5 fail, 202 pass in 19s

207 tests   202 ✅  19s ⏱️
 14 suites    0 💤
  1 files      5 ❌

Results for commit e3f982f.

Annotations

Check warning on line 0 in Contract API (e2e) /api POST returns HTTP 200 and contract verification id for single file Solidity contract

See this annotation in the file changed.

@github-actions github-actions / API E2E Test Results

Contract API (e2e) /api POST returns HTTP 200 and contract verification id for single file Solidity contract (Contract API (e2e) /api POST returns HTTP 200 and contract verification id for single file Solidity contract) failed 

packages/api/e2e-junit.xml [took 0s]
Raw output 
Error: expect(received).toStrictEqual(expected) // deep equality

- Expected  - 3
+ Received  + 3

  Object {
-   "message": "OK",
-   "result": "123",
-   "status": "1",
+   "message": "NOTOK",
+   "result": "Missing zksolcVersion",
+   "status": "0",
  }
    at Object.<anonymous> (/home/runner/work/block-explorer/block-explorer/packages/api/test/contract-api.e2e-spec.ts:369:10)
    at Promise.then.completed (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/run.js:121:9)
    at _runTestsForDescribeBlock (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/run.js:121:9)
    at run (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (/home/runner/work/block-explorer/block-explorer/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/home/runner/work/block-explorer/block-explorer/node_modules/jest-runner/build/runTest.js:444:34)
----
    at /home/runner/work/block-explorer/block-explorer/packages/api/test/contract-api.e2e-spec.ts:370:28
    at /home/runner/work/block-explorer/block-explorer/node_modules/supertest/lib/test.js:308:13
    at Test._assertFunction (/home/runner/work/block-explorer/block-explorer/node_modules/supertest/lib/test.js:285:13)
    at Test.assert (/home/runner/work/block-explorer/block-explorer/node_modules/supertest/lib/test.js:164:23)
    at Server.localAssert (/home/runner/work/block-explorer/block-explorer/node_modules/supertest/lib/test.js:120:14)
    at Object.onceWrapper (node:events:631:28)
    at Server.emit (node:events:517:28)
    at emitCloseNT (node:net:2221:8)
    at processTicksAndRejections (node:internal/process/task_queues:81:21)

Check warning on line 0 in Contract API (e2e) /api POST returns HTTP 200 and contract verification id for multi file Solidity contract

See this annotation in the file changed.

@github-actions github-actions / API E2E Test Results

Contract API (e2e) /api POST returns HTTP 200 and contract verification id for multi file Solidity contract (Contract API (e2e) /api POST returns HTTP 200 and contract verification id for multi file Solidity contract) failed 

packages/api/e2e-junit.xml [took 0s]
Raw output 
Error: expect(received).toStrictEqual(expected) // deep equality

- Expected  - 3
+ Received  + 3

  Object {
-   "message": "OK",
-   "result": "123",
-   "status": "1",
+   "message": "NOTOK",
+   "result": "Missing zksolcVersion",
+   "status": "0",
  }
    at Object.<anonymous> (/home/runner/work/block-explorer/block-explorer/packages/api/test/contract-api.e2e-spec.ts:411:10)
    at Promise.then.completed (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/run.js:121:9)
    at _runTestsForDescribeBlock (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/run.js:121:9)
    at run (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (/home/runner/work/block-explorer/block-explorer/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/home/runner/work/block-explorer/block-explorer/node_modules/jest-runner/build/runTest.js:444:34)
----
    at /home/runner/work/block-explorer/block-explorer/packages/api/test/contract-api.e2e-spec.ts:412:28
    at /home/runner/work/block-explorer/block-explorer/node_modules/supertest/lib/test.js:308:13
    at Test._assertFunction (/home/runner/work/block-explorer/block-explorer/node_modules/supertest/lib/test.js:285:13)
    at Test.assert (/home/runner/work/block-explorer/block-explorer/node_modules/supertest/lib/test.js:164:23)
    at Server.localAssert (/home/runner/work/block-explorer/block-explorer/node_modules/supertest/lib/test.js:120:14)
    at Object.onceWrapper (node:events:631:28)
    at Server.emit (node:events:517:28)
    at emitCloseNT (node:net:2221:8)
    at processTicksAndRejections (node:internal/process/task_queues:81:21)

Check warning on line 0 in Contract API (e2e) /api POST returns HTTP 200 and contract verification id for multi file Vyper contract

See this annotation in the file changed.

@github-actions github-actions / API E2E Test Results

Contract API (e2e) /api POST returns HTTP 200 and contract verification id for multi file Vyper contract (Contract API (e2e) /api POST returns HTTP 200 and contract verification id for multi file Vyper contract) failed 

packages/api/e2e-junit.xml [took 0s]
Raw output 
Error: expect(received).toStrictEqual(expected) // deep equality

- Expected  - 3
+ Received  + 3

  Object {
-   "message": "OK",
-   "result": "123",
-   "status": "1",
+   "message": "NOTOK",
+   "result": "Missing zksolcVersion",
+   "status": "0",
  }
    at Object.<anonymous> (/home/runner/work/block-explorer/block-explorer/packages/api/test/contract-api.e2e-spec.ts:463:10)
    at Promise.then.completed (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/run.js:121:9)
    at _runTestsForDescribeBlock (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/run.js:121:9)
    at run (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (/home/runner/work/block-explorer/block-explorer/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/home/runner/work/block-explorer/block-explorer/node_modules/jest-runner/build/runTest.js:444:34)
----
    at /home/runner/work/block-explorer/block-explorer/packages/api/test/contract-api.e2e-spec.ts:464:28
    at /home/runner/work/block-explorer/block-explorer/node_modules/supertest/lib/test.js:308:13
    at Test._assertFunction (/home/runner/work/block-explorer/block-explorer/node_modules/supertest/lib/test.js:285:13)
    at Test.assert (/home/runner/work/block-explorer/block-explorer/node_modules/supertest/lib/test.js:164:23)
    at Server.localAssert (/home/runner/work/block-explorer/block-explorer/node_modules/supertest/lib/test.js:120:14)
    at Object.onceWrapper (node:events:631:28)
    at Server.emit (node:events:517:28)
    at emitCloseNT (node:net:2221:8)
    at processTicksAndRejections (node:internal/process/task_queues:81:21)

Check warning on line 0 in Contract API (e2e) /api POST returns HTTP 200 with NOTOK result and validation message for 400 verification response

See this annotation in the file changed.

@github-actions github-actions / API E2E Test Results

Contract API (e2e) /api POST returns HTTP 200 with NOTOK result and validation message for 400 verification response (Contract API (e2e) /api POST returns HTTP 200 with NOTOK result and validation message for 400 verification response) failed 

packages/api/e2e-junit.xml [took 0s]
Raw output 
Error: expect(received).toStrictEqual(expected) // deep equality

- Expected  - 1
+ Received  + 1

  Object {
    "message": "NOTOK",
-   "result": "Contract has been already verified",
+   "result": "Missing zksolcVersion",
    "status": "0",
  }
    at Object.<anonymous> (/home/runner/work/block-explorer/block-explorer/packages/api/test/contract-api.e2e-spec.ts:491:10)
    at Promise.then.completed (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/run.js:121:9)
    at _runTestsForDescribeBlock (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/run.js:121:9)
    at run (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (/home/runner/work/block-explorer/block-explorer/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/home/runner/work/block-explorer/block-explorer/node_modules/jest-runner/build/runTest.js:444:34)
----
    at /home/runner/work/block-explorer/block-explorer/packages/api/test/contract-api.e2e-spec.ts:492:28
    at /home/runner/work/block-explorer/block-explorer/node_modules/supertest/lib/test.js:308:13
    at Test._assertFunction (/home/runner/work/block-explorer/block-explorer/node_modules/supertest/lib/test.js:285:13)
    at Test.assert (/home/runner/work/block-explorer/block-explorer/node_modules/supertest/lib/test.js:164:23)
    at Server.localAssert (/home/runner/work/block-explorer/block-explorer/node_modules/supertest/lib/test.js:120:14)
    at Object.onceWrapper (node:events:631:28)
    at Server.emit (node:events:517:28)
    at emitCloseNT (node:net:2221:8)
    at processTicksAndRejections (node:internal/process/task_queues:81:21)

Check warning on line 0 in Contract API (e2e) /api POST returns HTTP 200 with NOTOK and a generic error message for non 400 verification response

See this annotation in the file changed.

@github-actions github-actions / API E2E Test Results

Contract API (e2e) /api POST returns HTTP 200 with NOTOK and a generic error message for non 400 verification response (Contract API (e2e) /api POST returns HTTP 200 with NOTOK and a generic error message for non 400 verification response) failed 

packages/api/e2e-junit.xml [took 0s]
Raw output 
Error: expect(received).toStrictEqual(expected) // deep equality

- Expected  - 1
+ Received  + 1

  Object {
    "message": "NOTOK",
-   "result": "Failed to send verification request",
+   "result": "Missing zksolcVersion",
    "status": "0",
  }
    at Object.<anonymous> (/home/runner/work/block-explorer/block-explorer/packages/api/test/contract-api.e2e-spec.ts:517:10)
    at Promise.then.completed (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/run.js:121:9)
    at _runTestsForDescribeBlock (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/run.js:121:9)
    at run (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (/home/runner/work/block-explorer/block-explorer/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (/home/runner/work/block-explorer/block-explorer/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/home/runner/work/block-explorer/block-explorer/node_modules/jest-runner/build/runTest.js:444:34)
----
    at /home/runner/work/block-explorer/block-explorer/packages/api/test/contract-api.e2e-spec.ts:518:28
    at /home/runner/work/block-explorer/block-explorer/node_modules/supertest/lib/test.js:308:13
    at Test._assertFunction (/home/runner/work/block-explorer/block-explorer/node_modules/supertest/lib/test.js:285:13)
    at Test.assert (/home/runner/work/block-explorer/block-explorer/node_modules/supertest/lib/test.js:164:23)
    at Server.localAssert (/home/runner/work/block-explorer/block-explorer/node_modules/supertest/lib/test.js:120:14)
    at Object.onceWrapper (node:events:631:28)
    at Server.emit (node:events:517:28)
    at emitCloseNT (node:net:2221:8)
    at processTicksAndRejections (node:internal/process/task_queues:81:21)
View more details on GitHub Actions