feat: add system contracts on the first run #372
Conversation
API E2E Test Results207 tests 207 ✅ 20s ⏱️ Results for commit 89255da. ♻️ This comment has been updated with latest results. |
Unit Test Results 4 files 264 suites 12m 10s ⏱️ Results for commit 89255da. ♻️ This comment has been updated with latest results. |
|
Visit the preview URL for this PR: |
vasyl-ivanchuk
requested review from
vasyl-ivanchuk
and removed request for
Romsters
|
@kiriyaga-txfusion I've applied a few improvements, please check the changes. Another thing is that we require all commits to be signed. Otherwise you cannot merge the PR. So, I squashed all commits into a single signed commit. Please, make sure to configure GitHub to sign commits. |
vasyl-ivanchuk
force-pushed
the
kiriyaga-txfusion-add-system-contracts
branch
from
0a67d4d to
ebc4465
Compare
|
🎉 This PR is included in version 2.60.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
| const bytecode = await this.blockchainService.getCode(contract.address); | ||
| // some contract might not exist on the environment yet | ||
| if (bytecode !== "0x") { | ||
| await this.addressRepository.add({ |
There was a problem hiding this comment.
Could cause a problem, see #378
What ❔
This PR addresses an issue where system contracts were not displayed as contracts in the UI until they were updated. The implemented solution ensures that system contracts are loaded and saved in the database immediately after work begins. This guarantees their proper display in the UI, providing a consistent and accurate reflection of the system's state.
Why ❔
System contracts are not displayed as contracts in the UI until they have been updated.
Checklist
This PR fixes: #358