[MM-57843] Use official client for load-testing #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamer45
added
2: Dev Review
streamer45
commented
Apr 15, 2024
Comment on lines
-53
to
-57
| stopCh := make(chan struct{}) | ||
| var wg sync.WaitGroup | ||
| wg.Add(2) | ||
|
|
||
| userA := client.NewUser(client.Config{ |
There was a problem hiding this comment.
Unrelated but this wasn't really useful anymore since you implemented the scripting logic.
streamer45
added
3: Reviews Complete
streamer45
removed
the
Do Not Merge/Awaiting PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As a result of mattermost/rtcd#134, we can now use the official Golang client in our load-test implementation instead of a custom one.
Ticket Link
https://mattermost.atlassian.net/browse/MM-57843