feat: Test cases for Scheduled Message feature #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marianunez
requested changes
Sep 17, 2024
There was a problem hiding this comment.
Thanks @yasserfaraazkhan! Added some comments on additional cases we want to include.
Also, for the first version I believe we will be supporting moving a draft to a scheduled post. Is this correct @harshilsharma63 ? If so, we need to include test cases for add/remove schedule to drafts
data/test-cases/channels/schedule-messages/1-Create-Schedule-Messages.md
Outdated
Show resolved
Hide resolved
data/test-cases/channels/schedule-messages/4-Failed-Schedule-Message.md
Outdated
Show resolved
Hide resolved
data/test-cases/channels/schedule-messages/1-Create-Schedule-Messages.md
Outdated
Show resolved
Hide resolved
data/test-cases/channels/schedule-messages/1-Create-Schedule-Messages.md
Outdated
Show resolved
Hide resolved
lindalumitchell
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Nice, @yasserfaraazkhan! I added a bunch of nitpicky suggestions, plus I've started auditing the priorities set on our test cases, so these should be P3 in our custom priority field, as noted. Approving since the substance looks great; you can decide about my suggestions. :)
data/test-cases/channels/schedule-messages/1-Create-Schedule-Messages.md
Outdated
Show resolved
Hide resolved
data/test-cases/channels/schedule-messages/1-Create-Schedule-Messages.md
Outdated
Show resolved
Hide resolved
data/test-cases/channels/schedule-messages/6-Add-Schedule-to-Draft.md
Outdated
Show resolved
Hide resolved
data/test-cases/channels/schedule-messages/7-Remove-Schedule-and-Move-to-Draft.md
Outdated
Show resolved
Hide resolved
data/test-cases/channels/schedule-messages/7-Remove-Schedule-and-Move-to-Draft.md
Outdated
Show resolved
Hide resolved
data/test-cases/channels/schedule-messages/7-Remove-Schedule-and-Move-to-Draft.md
Outdated
Show resolved
Hide resolved
data/test-cases/channels/schedule-messages/7-Remove-Schedule-and-Move-to-Draft.md
Outdated
Show resolved
Hide resolved
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
harshilsharma63
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://mattermost.atlassian.net/browse/MM-60375