Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Scheduled messages): Mobile scheduled messages #200

Merged
merged 6 commits into from
Feb 25, 2025
Merged

Conversation

yasserfaraazkhan
Copy link
Collaborator

@yasserfaraazkhan yasserfaraazkhan changed the title featu(Scheduled messages): Mobile scheduled messages feat(Scheduled messages): Mobile scheduled messages Jan 30, 2025
Copy link

@rahimrahman rahimrahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small text suggestions.

And a suggestion (if available) on 1 of the scenario.


**Step 2**

### Scenario 2: Validate the "Schedule draft" button becomes active only when a valid time is selected.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an opposite of this? Validate that the button doesn't become active when you pick an invalid time? Not sure if it's possible to pick an invalid time, but if there is?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure @rahimrahman .
There isn't a invalid date picker. There is one case like below. I'll see how the UI will handle and update the test.

image

@yasserfaraazkhan yasserfaraazkhan merged commit 4271c4d into main Feb 25, 2025
1 check passed
@yasserfaraazkhan yasserfaraazkhan deleted the MM-62286 branch February 25, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants