Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates zephyr test cases for edit file attachment #201

Merged
merged 5 commits into from
Jan 30, 2025

Conversation

yasserfaraazkhan
Copy link
Collaborator

Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move each scenario as steps in Zephyr, such as **Step 2** to 6? With that, we can map each automated test as MM-T5654_1 to _6? Same comment to MM-T5655.

@yasserfaraazkhan
Copy link
Collaborator Author

yasserfaraazkhan commented Jan 27, 2025

Should we move each scenario as steps in Zephyr, such as **Step 2** to 6? With that, we can map each automated test as MM-T5654_1 to _6? Same comment to MM-T5655.

Hi @saturninoabril (can you help me if I got it right? )

You mean instead of Step_1, Step-2 in One file, have separate test files for all steps ?

Comment on lines 73 to 79
### Scenario 4: User should be able to edit post message originally containing files

1. Navigate to a Channel/Gm/DM where current user has a post with attachments.
2. Click the "Edit" option in the post actions menu.
3. Use the "Attach" button (paperclip icon) to upload a file or drag and drop a file into the editable area.
4. Save the edited post.
5. Verify the attachment is visible.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add **Step [n]** so this will be saved as step number in Zephyr and can be referenced as MM-T5654_4 in test report integration.

Suggested change
### Scenario 4: User should be able to edit post message originally containing files
1. Navigate to a Channel/Gm/DM where current user has a post with attachments.
2. Click the "Edit" option in the post actions menu.
3. Use the "Attach" button (paperclip icon) to upload a file or drag and drop a file into the editable area.
4. Save the edited post.
5. Verify the attachment is visible.
**Step 4**
### Scenario 4: User should be able to edit post message originally containing files
1. Navigate to a Channel/Gm/DM where current user has a post with attachments.
2. Click the "Edit" option in the post actions menu.
3. Use the "Attach" button (paperclip icon) to upload a file or drag and drop a file into the editable area.
4. Save the edited post.
5. Verify the attachment is visible.

@saturninoabril
Copy link
Member

You mean instead of Step_1, Step-2 in One file, have separate test files for all steps ?

You may modify as suggested at #201 (comment) or better organize into a separate test case so that a single test key does not contain too much scenarios.

@yasserfaraazkhan
Copy link
Collaborator Author

You mean instead of Step_1, Step-2 in One file, have separate test files for all steps ?

You may modify as suggested at #201 (comment) or better organize into a separate test case so that a single test key does not contain too much scenarios.

Got it Saturn
I'll add steps for these tests. I'll keep making more test files with concise scenarios in upcoming PRs

@yasserfaraazkhan yasserfaraazkhan merged commit 881618c into main Jan 30, 2025
1 check passed
@yasserfaraazkhan yasserfaraazkhan deleted the update_file_attachement_tests branch January 30, 2025 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants