Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MM-56540 - Live Captions: add client.Send #130

Merged
merged 10 commits into from
Mar 22, 2024
Merged

MM-56540 - Live Captions: add client.Send #130

merged 10 commits into from
Mar 22, 2024

Conversation

cpoile
Copy link
Member

@cpoile cpoile commented Jan 25, 2024 •
edited
Loading

Summary

  • Add a client.Send function
  • WIP -- needs tests

Ticket Link

@cpoile cpoile added the 2: Dev Review Requires review by a core committer label Jan 25, 2024
@cpoile cpoile requested a review from streamer45 January 25, 2024 21:48
@cpoile cpoile force-pushed the MM-56540-live-captions branch from e6dfdff to d815c24 Compare January 25, 2024 21:58
@cpoile cpoile added the Do Not Merge Should not be merged until this label is removed label Jan 25, 2024
streamer45
streamer45 approved these changes Jan 26, 2024
View reviewed changes
@streamer45 streamer45 added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Feb 9, 2024
@cpoile cpoile removed the Do Not Merge Should not be merged until this label is removed label Feb 13, 2024
@streamer45 streamer45 added this to the v0.13.1 milestone Mar 1, 2024
@streamer45 streamer45 self-requested a review March 21, 2024 19:35
streamer45
streamer45 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback but nothing blocking

@cpoile cpoile requested a review from streamer45 March 21, 2024 21:37
streamer45
streamer45 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, it's good, just nits.

@cpoile cpoile merged commit e9e2e1f into master Mar 22, 2024
2 checks passed
@cpoile cpoile deleted the MM-56540-live-captions branch March 22, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamer45 streamer45 streamer45 approved these changes

Assignees
No one assigned
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cpoile @streamer45