Fixed an issue caused by direct modification of fileId post meta in the database

maxguru · maxguru · commit 1f5e995c60df · 2021-09-17T23:39:12.000-07:00
diff --git a/modules/pdf-ninja.php b/modules/pdf-ninja.php
@@ -551,11 +551,10 @@ private function get_file_id( $attachment_id )
 		$file_id = WPCF7_Pdf_Forms::get_meta( $attachment_id, 'file_id' );
 		if( ! $file_id )
 		{
-			$file_id = substr($attachment_id . "-" . get_site_url(), 0, 40);
-			return WPCF7_Pdf_Forms::set_meta( $attachment_id, 'file_id', $file_id );
+			$file_id = substr( $attachment_id . "-" . get_site_url(), 0, 40 );
+			WPCF7_Pdf_Forms::set_meta( $attachment_id, 'file_id', $file_id );
 		}
-		else
-			return $file_id;
+		return substr( $file_id, 0, 40 );
 	}
 	
 	/*

Original file line number	Diff line number	Diff line change
`@@ -551,11 +551,10 @@ private function get_file_id( $attachment_id )`
`551`	`551`	`$file_id = WPCF7_Pdf_Forms::get_meta( $attachment_id, 'file_id' );`
`552`	`552`	`if( ! $file_id )`
`553`	`553`	`{`
`554`		`- $file_id = substr($attachment_id . "-" . get_site_url(), 0, 40);`
`555`		`- return WPCF7_Pdf_Forms::set_meta( $attachment_id, 'file_id', $file_id );`
	`554`	`+ $file_id = substr( $attachment_id . "-" . get_site_url(), 0, 40 );`
	`555`	`+ WPCF7_Pdf_Forms::set_meta( $attachment_id, 'file_id', $file_id );`
`556`	`556`	`}`
`557`		`- else`
`558`		`- return $file_id;`
	`557`	`+ return substr( $file_id, 0, 40 );`
`559`	`558`	`}`
`560`	`559`
`561`	`560`	`/*`