Switched to using a more concise file_put_contents()

Author: maxguru

modules/pdf-ninja.php

@@ -818,15 +818,7 @@ public function api_image( $destfile, $attachment_id, $page )
 		if( ! isset( $result['content'] ) || ! isset( $result['content_type'] ) || $result['content_type'] != 'image/jpeg' )
 			throw new Exception( __( "Pdf.Ninja API server did not send an expected response", 'pdf-forms-for-contact-form-7' ) );
 
-		$handle = @fopen( $destfile, 'w' );
-		
-		if( ! $handle )
-			throw new Exception( __( "Failed to open file for writing", 'pdf-forms-for-contact-form-7' ) );
-		
-		fwrite( $handle, $result['content'] );
-		fclose( $handle );
-		
-		if( ! file_exists( $destfile ) )
+		if( file_put_contents( $destfile, $result['content'] ) === false || ! is_file( $destfile ) )
 			throw new Exception( __( "Failed to create file", 'pdf-forms-for-contact-form-7' ) );
 
 		return true;
@@ -932,15 +924,7 @@ private function api_pdf_helper( $destfile, $endpoint, $attachment_id, $data, $e
 		if( ! isset( $result['content'] ) || ! isset( $result['content_type'] ) || $result['content_type'] != 'application/pdf' )
 			throw new Exception( __( "Pdf.Ninja API server did not send an expected response", 'pdf-forms-for-contact-form-7' ) );
 
-		$handle = @fopen( $destfile, 'w' );
-		
-		if( ! $handle )
-			throw new Exception( __( "Failed to open file for writing", 'pdf-forms-for-contact-form-7' ) );
-		
-		fwrite( $handle, $result['content'] );
-		fclose( $handle );
-		
-		if( ! file_exists( $destfile ) )
+		if( file_put_contents( $destfile, $result['content'] ) === false || ! is_file( $destfile ) )
 			throw new Exception( __( "Failed to create file", 'pdf-forms-for-contact-form-7' ) );
 
 		return true;

pdf-forms-for-contact-form-7.php

@@ -820,15 +820,7 @@ private static function download_file( $url, $filepath, &$mimetype = null )
 
 			$body = wp_remote_retrieve_body( $response );
 
-			$handle = @fopen( $filepath, 'w' );
-			
-			if( ! $handle )
-				throw new Exception( __( "Failed to open file for writing", 'pdf-forms-for-contact-form-7' ) );
-			
-			fwrite( $handle, $body );
-			fclose( $handle );
-			
-			if( ! is_file( $filepath ) )
+			if( file_put_contents( $filepath, $body ) === false || ! is_file( $filepath ) )
 				throw new Exception( __( "Failed to create file", 'pdf-forms-for-contact-form-7' ) );
 		}