Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored process.py, support datauris, upgraded tests #56

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

Bartvaderkin
Copy link
Contributor

@Bartvaderkin Bartvaderkin commented Mar 1, 2024

Closes #50

- reorganized code for top-down readability
- swapped generic tuples for NamedTuples
- reworked html testing
- dropped unnecessary test
- minor optimisations
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 95.60440% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 93.95%. Comparing base (82ac5bf) to head (f4e7453).

Files Patch % Lines
mail_editor/process.py 87.30% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage   93.64%   93.95%   +0.31%     
==========================================
  Files          30       31       +1     
  Lines        1038     1092      +54     
==========================================
+ Hits          972     1026      +54     
  Misses         66       66              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bartvaderkin Bartvaderkin merged commit 58ba97a into master Mar 1, 2024
12 checks passed
@Bartvaderkin Bartvaderkin deleted the fix/refactor branch March 1, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support attaching images from data URIs
2 participants