Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Always use requests.hostname for 2FA app title #442

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

stevenbal
Copy link
Collaborator

Fixes maykinmedia/open-api-framework#40 partially

Changes

  • Always use requests.hostname for 2FA app title

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.16%. Comparing base (a5a0a50) to head (c5c0c22).
Report is 35 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #442      +/-   ##
==========================================
- Coverage   95.18%   95.16%   -0.02%     
==========================================
  Files         150      154       +4     
  Lines        5105     5318     +213     
==========================================
+ Hits         4859     5061     +202     
- Misses        246      257      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevenbal stevenbal requested a review from annashamray August 29, 2024 14:29
@annashamray annashamray merged commit c47e459 into master Sep 18, 2024
14 checks passed
@annashamray annashamray deleted the feature/2fa-app-title branch September 18, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use URL and username for 2FA app titles
3 participants