New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAS check is not running on every push #115

Closed

7 tasks done

stevenbal opened this issue Mar 6, 2025 · 0 comments · Fixed by maykinmedia/objects-api#545, open-zaak/open-zaak#1929, open-zaak/open-notificaties#253, maykinmedia/objecttypes-api#159 or maykinmedia/open-klant#357

Assignees

Labels

bug owner: maykin

Collaborator

stevenbal commented Mar 6, 2025 •

edited

Loading

Product versie / Product version

latest

Omschrijf het probleem / Describe the bug

Noticed this in Objects API, currently the OAS check only runs if there are changes to openapi.yaml, while we want to use it to detect if we forgot to generate the schema. https://github.com/maykinmedia/objects-api/actions/workflows/oas-check.yml hasn't run in two months for example

Open Zaak 👷 [maykinmedia/open-api-framework#115] Always run OAS check open-zaak/open-zaak#1929
Open Notificaties 👷 [maykinmedia/open-api-framework#115] Always run OAS check open-zaak/open-notificaties#253
Objects API 👷 [maykinmedia/open-api-framework#115] Always run OAS check objects-api#545
Objecttypes API 👷 [maykinmedia/open-api-framework#115] Always run OAS check objecttypes-api#159
Open Klant 👷 [maykinmedia/open-api-framework#115] Always run OAS check open-klant#357
Referentielijsten 👷 [maykinmedia/open-api-framework#115] Always run OAS check referentielijsten#58
Open Producten

Stappen om te reproduceren / Steps to reproduce

No response

Verwacht gedrag / Expected behavior

It should check on every push, regardless of which files were changed

The text was updated successfully, but these errors were encountered:

stevenbal added the bug label

stevenbal added this to Data en API fundament

github-project-automation bot moved this to Triage in Data en API fundament

stevenbal self-assigned this

stevenbal added the owner: maykin label

stevenbal moved this from Triage to In Progress in Data en API fundament

stevenbal added a commit to maykinmedia/objects-api that referenced this issue


          👷 [maykinmedia/open-api-framework#115] Always run OAS check

87a80b5

to verify that the schema is up to date

stevenbal mentioned this issue

👷 [maykinmedia/open-api-framework#115] Always run OAS check maykinmedia/objects-api#545

Merged

stevenbal added a commit to maykinmedia/objects-api that referenced this issue


          👷 [maykinmedia/open-api-framework#115] Always run OAS check

to verify that the schema is up to date

stevenbal added a commit to maykinmedia/objects-api that referenced this issue


          👷 [maykinmedia/open-api-framework#115] Always run OAS check

b032847

to verify that the schema is up to date

stevenbal added a commit to open-zaak/open-zaak that referenced this issue


          👷 [maykinmedia/open-api-framework#115] Always run OAS check

to verify that the schema is up to date

stevenbal mentioned this issue

👷 [maykinmedia/open-api-framework#115] Always run OAS check open-zaak/open-zaak#1929

Merged

4 tasks

stevenbal added a commit to open-zaak/open-notificaties that referenced this issue


          👷 [maykinmedia/open-api-framework#115] Always run OAS check

7d932e6

to verify that the schema is up to date

stevenbal mentioned this issue

👷 [maykinmedia/open-api-framework#115] Always run OAS check open-zaak/open-notificaties#253

Merged

4 tasks

stevenbal added a commit to open-zaak/open-notificaties that referenced this issue


          👷 [maykinmedia/open-api-framework#115] Always run OAS check

fc19382

to verify that the schema is up to date

stevenbal added a commit to open-zaak/open-notificaties that referenced this issue


          📝 [maykinmedia/open-api-framework#115] Regenerate schema

0d8b848

to add translated messages

stevenbal added a commit to open-zaak/open-notificaties that referenced this issue


          📝 [maykinmedia/open-api-framework#115] Regenerate schema

a45847e

to add translated messages

stevenbal added a commit to open-zaak/open-notificaties that referenced this issue


          📝 [maykinmedia/open-api-framework#115] Regenerate schema

cb45b4a

to add translated messages

stevenbal added a commit to open-zaak/open-notificaties that referenced this issue


          👷 [maykinmedia/open-api-framework#115] Always run OAS check

ab68959

to verify that the schema is up to date

stevenbal added a commit to open-zaak/open-notificaties that referenced this issue


          📝 [maykinmedia/open-api-framework#115] Regenerate schema

795f5b1

to add translated messages

stevenbal added a commit to open-zaak/open-notificaties that referenced this issue


          📝 [maykinmedia/open-api-framework#115] Regenerate schema

c3e8053

to add translated messages

stevenbal added a commit to open-zaak/open-notificaties that referenced this issue


          👷 [maykinmedia/open-api-framework#115] Always run OAS check

487b678

to verify that the schema is up to date

stevenbal added a commit to open-zaak/open-notificaties that referenced this issue


          📝 [maykinmedia/open-api-framework#115] Regenerate schema

3c81e54

to add translated messages

stevenbal added a commit to open-zaak/open-notificaties that referenced this issue


          📝 [maykinmedia/open-api-framework#115] Regenerate schema

5114c08

to add translated messages

stevenbal added a commit to open-zaak/open-notificaties that referenced this issue


          📝 [maykinmedia/open-api-framework#115] Regenerate schema

c1429d5

to add translated messages

stevenbal added a commit to open-zaak/open-zaak that referenced this issue


          👷 [maykinmedia/open-api-framework#115] Always run OAS check

43b849d

to verify that the schema is up to date

stevenbal added a commit to open-zaak/open-notificaties that referenced this issue


          📝 [maykinmedia/open-api-framework#115] Regenerate schema

1258b18

to add translated messages

stevenbal added a commit to open-zaak/open-zaak that referenced this issue


          👷 [maykinmedia/open-api-framework#115] Always run OAS check

5fe30cd

to verify that the schema is up to date

stevenbal added a commit to open-zaak/open-notificaties that referenced this issue


          📝 [maykinmedia/open-api-framework#115] Regenerate schema

c025fca

to add translated messages

stevenbal added a commit to open-zaak/open-notificaties that referenced this issue


          📝 [maykinmedia/open-api-framework#115] Regenerate schema

4a12edf

to add translated messages

stevenbal added a commit to open-zaak/open-zaak that referenced this issue


          Merge pull request #1929 from open-zaak/issue/fix-oas-check

8984c89

👷 [maykinmedia/open-api-framework#115] Always run OAS check

stevenbal closed this as completed in open-zaak/open-zaak#1929

github-project-automation bot moved this from In Progress to Done in Data en API fundament

stevenbal reopened this

github-project-automation bot moved this from Done to In Progress in Data en API fundament

stevenbal closed this as completed in open-zaak/open-notificaties#253

stevenbal added a commit to open-zaak/open-notificaties that referenced this issue


          Merge pull request #253 from open-zaak/issue/fix-oas-check

e66f8f2

👷 [maykinmedia/open-api-framework#115] Always run OAS check

github-project-automation bot moved this from In Progress to Done in Data en API fundament

stevenbal added a commit to maykinmedia/referentielijsten that referenced this issue


          Merge pull request #58 from maykinmedia/issue/fix-oas-check

e24518d

👷 [maykinmedia/open-api-framework#115] Always run OAS check

stevenbal reopened this

github-project-automation bot moved this from Done to In Progress in Data en API fundament

stevenbal added a commit to maykinmedia/open-klant that referenced this issue


          🔧 [maykinmedia/open-api-framework#115] Explicitly generate OAS in Dutch

7fb745b

stevenbal added a commit to maykinmedia/open-klant that referenced this issue


          👷 [maykinmedia/open-api-framework#115] Always run OAS check

2a2f042

to verify that the schema is up to date

stevenbal added a commit to maykinmedia/open-klant that referenced this issue


          🔧 [maykinmedia/open-api-framework#115] Explicitly generate OAS in Dutch

cb0b121

stevenbal moved this from In Progress to Implemented in Data en API fundament

stevenbal closed this as completed in maykinmedia/open-klant#357

stevenbal added a commit to maykinmedia/open-klant that referenced this issue


          Merge pull request #357 from maykinmedia/issue/fix-oas-check

b0551fb

👷 [maykinmedia/open-api-framework#115] Always run OAS check

github-project-automation bot moved this from Implemented to Done in Data en API fundament

stevenbal reopened this

github-project-automation bot moved this from Done to In Progress in Data en API fundament

stevenbal moved this from In Progress to Implemented in Data en API fundament

stevenbal added a commit to maykinmedia/objects-api that referenced this issue


          👷 [maykinmedia/open-api-framework#115] Always run OAS check

c757d47

to verify that the schema is up to date

stevenbal added a commit to maykinmedia/objects-api that referenced this issue


          📝 [maykinmedia/open-api-framework#115] Regenerate schema

90eb4b5

stevenbal added a commit to maykinmedia/objecttypes-api that referenced this issue


          📝 [maykinmedia/open-api-framework#115] Regenerate schema

c98655b

and explicitly generate it in English

stevenbal added a commit to maykinmedia/objecttypes-api that referenced this issue


          👷 [maykinmedia/open-api-framework#115] Always run OAS check

b1f2387

to verify that the schema is up to date

stevenbal added a commit to maykinmedia/objecttypes-api that referenced this issue


          📝 [maykinmedia/open-api-framework#115] Regenerate schema

b2b87fa

and explicitly generate it in English

stevenbal added a commit to maykinmedia/objects-api that referenced this issue


          Merge pull request #545 from maykinmedia/issue/fix-oas-check

9ae7d61

👷 [maykinmedia/open-api-framework#115] Always run OAS check

stevenbal closed this as completed in maykinmedia/objects-api#545

github-project-automation bot moved this from Implemented to Done in Data en API fundament

stevenbal added a commit to maykinmedia/objecttypes-api that referenced this issue


          Merge pull request #159 from maykinmedia/issue/fix-oas-check

eab1209

👷 [maykinmedia/open-api-framework#115] Always run OAS check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment