[#310] Improve migrations and tests

Author: danielmursa-dev

src/openklant/components/contactgegevens/migrations/0005_alter_organisatie_adres_nummeraanduiding_id_and_more.py

@@ -13,17 +13,18 @@
 def _check_records(records, model_name):
     total_failed_records = 0
     for record in records:
-        try:
-            validate_bag_id(record.adres_nummeraanduiding_id)
-        except ValidationError:
-            logger.warning(
-                "%s(pk=%s, uuid=%s) Field: 'adres_nummeraanduiding_id'. Invalid BAG ID: %s",
-                model_name,
-                record.pk,
-                record.uuid,
-                record.adres_nummeraanduiding_id,
-            )
-            total_failed_records += 1
+        if record.adres_nummeraanduiding_id:
+            try:
+                validate_bag_id(record.adres_nummeraanduiding_id)
+            except ValidationError:
+                logger.warning(
+                    "%s(pk=%s, uuid=%s) Field: 'adres_nummeraanduiding_id'. Invalid BAG ID: %s",
+                    model_name,
+                    record.pk,
+                    record.uuid,
+                    record.adres_nummeraanduiding_id,
+                )
+                total_failed_records += 1
     return total_failed_records
 
 

src/openklant/components/contactgegevens/tests/test_migrations.py

@@ -214,6 +214,21 @@ def test_ok_migration_organisatie_model(self):
         self.assertEqual(records.count(), 1)
         self.assertEqual(records[0].adres_nummeraanduiding_id, "1234567890000001")
 
+    def test_ok_migration_organisatie_model_empty_value(self):
+
+        Organisatie = self.old_app_state.get_model("contactgegevens", "Organisatie")
+
+        Organisatie.objects.create(adres_nummeraanduiding_id="")
+
+        self._perform_migration()
+
+        Organisatie = self.apps.get_model("contactgegevens", "Organisatie")
+
+        records = Organisatie.objects.all()
+
+        self.assertEqual(records.count(), 1)
+        self.assertEqual(records[0].adres_nummeraanduiding_id, "")
+
     def test_ko_migration_organisatie_model_wrong_code(self):
 
         Organisatie = self.old_app_state.get_model("contactgegevens", "Organisatie")
@@ -266,6 +281,21 @@ def test_ok_migrate_persoon_model(self):
         self.assertEqual(records.count(), 1)
         self.assertEqual(records[0].adres_nummeraanduiding_id, "1234567890000001")
 
+    def test_ok_migration_persoon_model_empty_value(self):
+
+        Persoon = self.old_app_state.get_model("contactgegevens", "Persoon")
+
+        Persoon.objects.create(adres_nummeraanduiding_id="", geboortedatum="1980-02-23")
+
+        self._perform_migration()
+
+        Persoon = self.apps.get_model("contactgegevens", "Persoon")
+
+        records = Persoon.objects.all()
+
+        self.assertEqual(records.count(), 1)
+        self.assertEqual(records[0].adres_nummeraanduiding_id, "")
+
     def test_ko_migration_persoon_model_wrong_code(self):
 
         Persoon = self.old_app_state.get_model("contactgegevens", "Persoon")

src/openklant/components/klantinteracties/migrations/0027_alter_betrokkene_bezoekadres_nummeraanduiding_id_and_more.py

@@ -18,19 +18,20 @@ def _check_records(records, model_name):
             "bezoekadres_nummeraanduiding_id",
             "correspondentieadres_nummeraanduiding_id",
         ):
-            try:
-                field_value = getattr(record, field_name, None)
-                validate_bag_id(field_value)
-            except ValidationError:
-                logger.warning(
-                    "%s(pk=%s, uuid=%s) Field: '%s'. Invalid BAG ID: %s",
-                    model_name,
-                    record.pk,
-                    record.uuid,
-                    field_name,
-                    field_value,
-                )
-                record_failed = True
+            field_value = getattr(record, field_name, None)
+            if field_value:
+                try:
+                    validate_bag_id(field_value)
+                except ValidationError:
+                    logger.warning(
+                        "%s(pk=%s, uuid=%s) Field: '%s'. Invalid BAG ID: %s",
+                        model_name,
+                        record.pk,
+                        record.uuid,
+                        field_name,
+                        field_value,
+                    )
+                    record_failed = True
 
         if record_failed:
             total_failed_records += 1

src/openklant/components/klantinteracties/tests/test_migrations.py

@@ -277,6 +277,28 @@ def test_ok_migration_betrokkene_model(self):
             records[0].correspondentieadres_nummeraanduiding_id, "1234567890000002"
         )
 
+    def test_ok_migration_betrokkene_model_empty_value(self):
+
+        Betrokkene = self.old_app_state.get_model("klantinteracties", "Betrokkene")
+        Klantcontact = self.old_app_state.get_model("klantinteracties", "Klantcontact")
+
+        Betrokkene.objects.create(
+            partij=None,
+            klantcontact=Klantcontact.objects.create(vertrouwelijk=False),
+            initiator=False,
+            bezoekadres_nummeraanduiding_id="",
+            correspondentieadres_nummeraanduiding_id="",
+        )
+
+        self._perform_migration()
+
+        Betrokkene = self.apps.get_model("klantinteracties", "Betrokkene")
+
+        records = Betrokkene.objects.all()
+        self.assertEqual(records.count(), 1)
+        self.assertEqual(records[0].bezoekadres_nummeraanduiding_id, "")
+        self.assertEqual(records[0].correspondentieadres_nummeraanduiding_id, "")
+
     def test_ko_migration_betrokkene_model_wrong_code(self):
 
         Betrokkene = self.old_app_state.get_model("klantinteracties", "Betrokkene")
@@ -348,6 +370,26 @@ def test_ok_migration_partij_model(self):
             records[0].correspondentieadres_nummeraanduiding_id, "1234567890000002"
         )
 
+    def test_ok_migration_partij_model_empty_value(self):
+
+        Partij = self.old_app_state.get_model("klantinteracties", "Partij")
+
+        Partij.objects.create(
+            indicatie_actief=True,
+            bezoekadres_nummeraanduiding_id="",
+            correspondentieadres_nummeraanduiding_id="",
+        )
+
+        self._perform_migration()
+
+        Partij = self.apps.get_model("klantinteracties", "Partij")
+
+        records = Partij.objects.all()
+
+        self.assertEqual(records.count(), 1)
+        self.assertEqual(records[0].bezoekadres_nummeraanduiding_id, "")
+        self.assertEqual(records[0].correspondentieadres_nummeraanduiding_id, "")
+
     def test_ko_migration_partij_model_wrong_code(self):
 
         Partij = self.old_app_state.get_model("klantinteracties", "Partij")