[#239] Updated factories

Author: danielmursa-dev

src/openklant/components/klantinteracties/api/tests/test_partijen.py

@@ -2148,12 +2148,9 @@ def _get_detail_url(partij: Partij) -> str:
 
     def test_get_partij_and_partij_identificatoren(self):
         partij = PartijFactory.create()
-        partij_identificator = PartijIdentificatorFactory.create(
+        partij_identificator = BsnPartijIdentificatorFactory.create(
             partij=partij,
-            partij_identificator_code_objecttype="natuurlijk_persoon",
-            partij_identificator_code_soort_object_id="bsn",
             partij_identificator_object_id="296648875",
-            partij_identificator_code_register="brp",
         )
         detail_url = reverse(
             "klantinteracties:partij-detail", kwargs={"uuid": str(partij.uuid)}
@@ -2417,13 +2414,9 @@ def test_create_partij_identificator(self):
 
     def test_update_partij_identificator(self):
         partij, partij2 = PartijFactory.create_batch(2)
-        partij_identificator = PartijIdentificatorFactory.create(
+        partij_identificator = BsnPartijIdentificatorFactory.create(
             partij=partij,
-            andere_partij_identificator="anderePartijIdentificator",
-            partij_identificator_code_objecttype="natuurlijk_persoon",
-            partij_identificator_code_soort_object_id="bsn",
             partij_identificator_object_id="296648875",
-            partij_identificator_code_register="brp",
         )
 
         detail_url = reverse(
@@ -2474,13 +2467,10 @@ def test_update_partij_identificator(self):
 
     def test_partial_update_partij_identificator(self):
         partij = PartijFactory.create()
-        partij_identificator = PartijIdentificatorFactory.create(
+        partij_identificator = BsnPartijIdentificatorFactory.create(
             partij=partij,
             andere_partij_identificator="anderePartijIdentificator",
-            partij_identificator_code_objecttype="natuurlijk_persoon",
-            partij_identificator_code_soort_object_id="bsn",
             partij_identificator_object_id="296648875",
-            partij_identificator_code_register="brp",
         )
 
         detail_url = reverse(
@@ -2676,13 +2666,10 @@ def test_invalid_update_partial(self):
         # all partij_identificator fields required
         partij = PartijFactory.create()
         list_url = reverse("klantinteracties:partijidentificator-list")
-        partij_identificator = PartijIdentificatorFactory.create(
+        partij_identificator = BsnPartijIdentificatorFactory.create(
             partij=partij,
             andere_partij_identificator="anderePartijIdentificator",
-            partij_identificator_code_objecttype="natuurlijk_persoon",
-            partij_identificator_code_soort_object_id="bsn",
             partij_identificator_object_id="123456782",
-            partij_identificator_code_register="brp",
         )
 
         data = {
@@ -2732,13 +2719,10 @@ def test_valid_create(self):
         self.assertEqual(PartijIdentificator.objects.all().count(), 1)
 
     def test_valid_create_with_sub_identificator_van(self):
-        partij_identificator = PartijIdentificatorFactory.create(
+        partij_identificator = KvkNummerPartijIdentificatorFactory.create(
             partij=self.partij,
             andere_partij_identificator="anderePartijIdentificator",
-            partij_identificator_code_objecttype="niet_natuurlijk_persoon",
-            partij_identificator_code_soort_object_id="kvk_nummer",
             partij_identificator_object_id="12345678",
-            partij_identificator_code_register="hr",
         )
         data = {
             "identificeerdePartij": {"uuid": str(self.partij.uuid)},
@@ -2770,9 +2754,9 @@ def test_invalid_create_partij_required(self):
         self.assertEqual(error["reason"], "Dit veld is vereist.")
 
     def test_invalid_create_duplicate_code_soort_object_id_for_partij(self):
-        PartijIdentificatorFactory.create(
+        BsnPartijIdentificatorFactory.create(
             partij=self.partij,
-            partij_identificator_code_soort_object_id="bsn",
+            partij_identificator_object_id="296648875",
         )
 
         data = {
@@ -2794,13 +2778,10 @@ def test_invalid_create_duplicate_code_soort_object_id_for_partij(self):
         )
 
     def test_valid_update_partij(self):
-        partij_identificator = PartijIdentificatorFactory.create(
+        partij_identificator = BsnPartijIdentificatorFactory.create(
             partij=PartijFactory.create(),
             andere_partij_identificator="anderePartijIdentificator",
-            partij_identificator_code_objecttype="natuurlijk_persoon",
-            partij_identificator_code_soort_object_id="bsn",
             partij_identificator_object_id="123456782",
-            partij_identificator_code_register="brp",
         )
         data = {
             "identificeerdePartij": {"uuid": str(self.partij.uuid)},
@@ -2819,22 +2800,15 @@ def test_valid_update_partij(self):
 
     def test_invalid_update_partij(self):
         new_partij = PartijFactory.create()
-        PartijIdentificatorFactory.create(
+        BsnPartijIdentificatorFactory.create(
             partij=new_partij,
             andere_partij_identificator="anderePartijIdentificator",
-            partij_identificator_code_objecttype="natuurlijk_persoon",
-            partij_identificator_code_soort_object_id="bsn",
             partij_identificator_object_id="123456782",
-            partij_identificator_code_register="brp",
         )
-
-        partij_identificator = PartijIdentificatorFactory.create(
+        partij_identificator = BsnPartijIdentificatorFactory.create(
             partij=self.partij,
             andere_partij_identificator="anderePartijIdentificator",
-            partij_identificator_code_objecttype="natuurlijk_persoon",
-            partij_identificator_code_soort_object_id="bsn",
             partij_identificator_object_id="296648875",
-            partij_identificator_code_register="brp",
         )
         data = {
             "identificeerdePartij": {"uuid": str(new_partij.uuid)},
@@ -2871,15 +2845,11 @@ def test_invalid_update_partij(self):
         )
 
     def test_valid_update_check_uniqueness_values(self):
-        partij_identificator = PartijIdentificatorFactory.create(
+        partij_identificator = BsnPartijIdentificatorFactory.create(
             partij=self.partij,
             andere_partij_identificator="anderePartijIdentificator",
-            partij_identificator_code_objecttype="natuurlijk_persoon",
-            partij_identificator_code_soort_object_id="bsn",
             partij_identificator_object_id="123456782",
-            partij_identificator_code_register="brp",
         )
-
         data = {
             "identificeerdePartij": {"uuid": str(self.partij.uuid)},
             "anderePartijIdentificator": "changed",
@@ -2911,20 +2881,13 @@ def test_valid_update_check_uniqueness_values(self):
         )
 
     def test_invalid_update_check_uniqueness_exists(self):
-        partij_identificator_a = PartijIdentificatorFactory.create(
+        partij_identificator_a = BsnPartijIdentificatorFactory.create(
             partij=self.partij,
-            partij_identificator_code_objecttype="natuurlijk_persoon",
-            partij_identificator_code_soort_object_id="bsn",
             partij_identificator_object_id="123456782",
-            partij_identificator_code_register="brp",
         )
-
-        partij_identificator_b = PartijIdentificatorFactory.create(
+        partij_identificator_b = BsnPartijIdentificatorFactory.create(
             partij=PartijFactory.create(),
-            partij_identificator_code_objecttype="natuurlijk_persoon",
-            partij_identificator_code_soort_object_id="bsn",
             partij_identificator_object_id="296648875",
-            partij_identificator_code_register="brp",
         )
         # update partij_identificator_a with partij_identificator_b data
         detail_url = reverse(
@@ -2953,21 +2916,15 @@ def test_invalid_update_check_uniqueness_exists(self):
         )
 
     def test_valid_check_uniqueness_sub_identificator_van(self):
-        PartijIdentificatorFactory.create(
+        BsnPartijIdentificatorFactory.create(
             partij=self.partij,
-            partij_identificator_code_objecttype="natuurlijk_persoon",
-            partij_identificator_code_soort_object_id="bsn",
             partij_identificator_object_id="296648875",
-            partij_identificator_code_register="brp",
         )
         # Same values, but sub_identifier_van is set
         partij = PartijFactory.create()
-        sub_identificator_van = PartijIdentificatorFactory.create(
+        sub_identificator_van = KvkNummerPartijIdentificatorFactory.create(
             partij=partij,
-            partij_identificator_code_objecttype="niet_natuurlijk_persoon",
-            partij_identificator_code_soort_object_id="kvk_nummer",
             partij_identificator_object_id="12345678",
-            partij_identificator_code_register="hr",
         )
         self.assertEqual(PartijIdentificator.objects.all().count(), 2)
         data = {
@@ -2985,20 +2942,14 @@ def test_valid_check_uniqueness_sub_identificator_van(self):
         self.assertEqual(PartijIdentificator.objects.all().count(), 3)
 
     def test_invalid_check_uniqueness_sub_identificator_van(self):
-        sub_identificator_van = PartijIdentificatorFactory.create(
+        sub_identificator_van = KvkNummerPartijIdentificatorFactory.create(
             partij=self.partij,
-            partij_identificator_code_objecttype="niet_natuurlijk_persoon",
-            partij_identificator_code_soort_object_id="kvk_nummer",
             partij_identificator_object_id="12345678",
-            partij_identificator_code_register="hr",
         )
-        PartijIdentificatorFactory.create(
+        BsnPartijIdentificatorFactory.create(
             partij=self.partij,
             sub_identificator_van=sub_identificator_van,
-            partij_identificator_code_objecttype="natuurlijk_persoon",
-            partij_identificator_code_soort_object_id="bsn",
             partij_identificator_object_id="296648875",
-            partij_identificator_code_register="brp",
         )
         self.assertEqual(PartijIdentificator.objects.all().count(), 2)
         # Same values and same sub_identificator_van
@@ -3023,12 +2974,9 @@ def test_invalid_check_uniqueness_sub_identificator_van(self):
         self.assertEqual(PartijIdentificator.objects.all().count(), 2)
 
     def test_vestigingsnummer_valid_create(self):
-        sub_identificator_van = PartijIdentificatorFactory.create(
+        sub_identificator_van = KvkNummerPartijIdentificatorFactory.create(
             partij=self.partij,
-            partij_identificator_code_objecttype="niet_natuurlijk_persoon",
-            partij_identificator_code_soort_object_id="kvk_nummer",
             partij_identificator_object_id="12345678",
-            partij_identificator_code_register="hr",
         )
 
         data = {
@@ -3072,12 +3020,9 @@ def test_vestigingsnummer_invalid_create_without_sub_identificator_van(self):
         )
 
     def test_vestigingsnummer_invalid_create_without_partij(self):
-        sub_identificator_van = PartijIdentificatorFactory.create(
+        sub_identificator_van = KvkNummerPartijIdentificatorFactory.create(
             partij=self.partij,
-            partij_identificator_code_objecttype="niet_natuurlijk_persoon",
-            partij_identificator_code_soort_object_id="kvk_nummer",
             partij_identificator_object_id="12345678",
-            partij_identificator_code_register="hr",
         )
 
         data = {
@@ -3098,12 +3043,9 @@ def test_vestigingsnummer_invalid_create_without_partij(self):
 
     def test_vestigingsnummer_valid_create_external_partij(self):
         partij = PartijFactory.create()
-        sub_identificator_van = PartijIdentificatorFactory.create(
+        sub_identificator_van = KvkNummerPartijIdentificatorFactory.create(
             partij=partij,
-            partij_identificator_code_objecttype="niet_natuurlijk_persoon",
-            partij_identificator_code_soort_object_id="kvk_nummer",
             partij_identificator_object_id="12345678",
-            partij_identificator_code_register="hr",
         )
 
         # sub_identificator_van partij is different from vestigingsnummer partij
@@ -3122,13 +3064,11 @@ def test_vestigingsnummer_valid_create_external_partij(self):
         self.assertEqual(PartijIdentificator.objects.all().count(), 2)
 
     def test_vestigingsnummer_invalid_create_invalid_sub_identificator_van(self):
-        sub_identificator_van = PartijIdentificatorFactory.create(
+        sub_identificator_van = BsnPartijIdentificatorFactory.create(
             partij=self.partij,
-            partij_identificator_code_objecttype="natuurlijk_persoon",
-            partij_identificator_code_soort_object_id="bsn",
             partij_identificator_object_id="296648875",
-            partij_identificator_code_register="brp",
         )
+
         data = {
             "identificeerdePartij": {"uuid": str(self.partij.uuid)},
             "sub_identificator_van": {"uuid": str(sub_identificator_van.uuid)},
@@ -3150,20 +3090,14 @@ def test_vestigingsnummer_invalid_create_invalid_sub_identificator_van(self):
         )
 
     def test_vestigingsnummer_valid_update(self):
-        sub_identificator_van = PartijIdentificatorFactory.create(
+        sub_identificator_van = KvkNummerPartijIdentificatorFactory.create(
             partij=self.partij,
-            partij_identificator_code_objecttype="niet_natuurlijk_persoon",
-            partij_identificator_code_soort_object_id="kvk_nummer",
             partij_identificator_object_id="12345678",
-            partij_identificator_code_register="hr",
         )
-        partij_identificator = PartijIdentificatorFactory.create(
+        partij_identificator = VestigingsnummerPartijIdentificatorFactory.create(
             partij=self.partij,
             sub_identificator_van=sub_identificator_van,
-            partij_identificator_code_objecttype="vestiging",
-            partij_identificator_code_soort_object_id="vestigingsnummer",
             partij_identificator_object_id="111122223333",
-            partij_identificator_code_register="hr",
         )
 
         self.assertEqual(PartijIdentificator.objects.count(), 2)
@@ -3192,20 +3126,14 @@ def test_vestigingsnummer_valid_update(self):
         )
 
     def test_vestigingsnummer_invalid_update_set_sub_identificator_van_null(self):
-        sub_identificator_van = PartijIdentificatorFactory.create(
+        sub_identificator_van = KvkNummerPartijIdentificatorFactory.create(
             partij=self.partij,
-            partij_identificator_code_objecttype="niet_natuurlijk_persoon",
-            partij_identificator_code_soort_object_id="kvk_nummer",
             partij_identificator_object_id="12345678",
-            partij_identificator_code_register="hr",
         )
-        partij_identificator = PartijIdentificatorFactory.create(
+        partij_identificator = VestigingsnummerPartijIdentificatorFactory.create(
             partij=self.partij,
             sub_identificator_van=sub_identificator_van,
-            partij_identificator_code_objecttype="vestiging",
-            partij_identificator_code_soort_object_id="vestigingsnummer",
             partij_identificator_object_id="111122223333",
-            partij_identificator_code_register="hr",
         )
 
         self.assertEqual(PartijIdentificator.objects.count(), 2)
@@ -3231,20 +3159,14 @@ def test_vestigingsnummer_invalid_update_set_sub_identificator_van_null(self):
         )
 
     def test_invalid_vestigingsnummer_and_kvk_nummer_combination_unique(self):
-        sub_identificator_van = PartijIdentificatorFactory.create(
+        sub_identificator_van = KvkNummerPartijIdentificatorFactory.create(
             partij=self.partij,
-            partij_identificator_code_objecttype="niet_natuurlijk_persoon",
-            partij_identificator_code_soort_object_id="kvk_nummer",
             partij_identificator_object_id="12345678",
-            partij_identificator_code_register="hr",
         )
-        PartijIdentificatorFactory.create(
+        VestigingsnummerPartijIdentificatorFactory.create(
             partij=self.partij,
             sub_identificator_van=sub_identificator_van,
-            partij_identificator_code_objecttype="vestiging",
-            partij_identificator_code_soort_object_id="vestigingsnummer",
             partij_identificator_object_id="296648875154",
-            partij_identificator_code_register="hr",
         )
         # Same sub_identificator_van and same data_values
         data = {
@@ -3273,12 +3195,9 @@ def test_invalid_vestigingsnummer_and_kvk_nummer_combination_unique(self):
         )
 
     def test_valid_protect_delete(self):
-        partij_identificator = PartijIdentificatorFactory.create(
+        partij_identificator = KvkNummerPartijIdentificatorFactory.create(
             partij=self.partij,
-            partij_identificator_code_objecttype="niet_natuurlijk_persoon",
-            partij_identificator_code_soort_object_id="kvk_nummer",
             partij_identificator_object_id="12345678",
-            partij_identificator_code_register="hr",
         )
         detail_url = reverse(
             "klantinteracties:partijidentificator-detail",
@@ -3290,20 +3209,14 @@ def test_valid_protect_delete(self):
         self.assertEqual(PartijIdentificator.objects.all().count(), 0)
 
     def test_invalid_protect_delete(self):
-        sub_identificator_van = PartijIdentificatorFactory.create(
+        sub_identificator_van = KvkNummerPartijIdentificatorFactory.create(
             partij=self.partij,
-            partij_identificator_code_objecttype="niet_natuurlijk_persoon",
-            partij_identificator_code_soort_object_id="kvk_nummer",
             partij_identificator_object_id="12345678",
-            partij_identificator_code_register="hr",
         )
-        PartijIdentificatorFactory.create(
+        VestigingsnummerPartijIdentificatorFactory.create(
             partij=self.partij,
             sub_identificator_van=sub_identificator_van,
-            partij_identificator_code_objecttype="vestiging",
-            partij_identificator_code_soort_object_id="vestigingsnummer",
             partij_identificator_object_id="296648875154",
-            partij_identificator_code_register="hr",
         )
         detail_url = reverse(
             "klantinteracties:partijidentificator-detail",