Merge pull request #357 from maykinmedia/issue/fix-oas-check

👷 [maykinmedia/open-api-framework#115] Always run OAS check
maykinmedia · Mar 7, 2025 · b0551fb · b0551fb
2 parents 95b727c + cb0b121
commit b0551fb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/.github/workflows/oas-check.yml b/.github/workflows/oas-check.yml
@@ -2,24 +2,19 @@ name: check-oas
 
 on:
   push:
-    paths:
-      - "src/openklant/components/*/openapi.yaml"
-      - .github/workflows/oas-check.yml
-    branches:
-      - '**'
   workflow_dispatch:
 
 jobs:
   open-api-workflow-check-oas:
-    uses: maykinmedia/open-api-workflows/.github/workflows/oas-check.yml@v1
+    uses: maykinmedia/open-api-workflows/.github/workflows/oas-check.yml@v5.0.0
     strategy:
       matrix:
         component:
           - contactgegevens
           - klantinteracties
     with:
       schema-path: 'src/openklant/components/${{ matrix.component }}/openapi.yaml'
-      schema-command: 'spectacular_for_component'
-      schema-options: "--component ${{ matrix.component }}"
+      schema-command: 'bin/generate_schema_for_component.sh'
+      schema-options: "${{ matrix.component }} src/openklant/components/${{ matrix.component }}/openapi.yaml"
       python-version: '3.11'
       django-settings-module: 'openklant.conf.ci'
diff --git a/bin/generate_schema_for_component.sh b/bin/generate_schema_for_component.sh
@@ -22,6 +22,8 @@ OUTPUT_FILE=$2
 echo "Generating OAS schema for $1..."
 src/manage.py spectacular_for_component \
     --file ${OUTPUT_FILE:-$SCHEMA_PATH/openapi.yaml} \
+    --lang="nl-nl" \
+    --validate \
     --component $1
 
 echo "Done."