Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#21] display version in admin #192

Merged
merged 6 commits into from
Jul 16, 2024
Merged

Conversation

SonnyBA
Copy link
Contributor

@SonnyBA SonnyBA commented Jun 7, 2024

Partially fixes maykinmedia/open-api-framework#21

Changes

Shows the current version of the application in the admin:

image

@SonnyBA SonnyBA requested review from Coperh and bart-maykin June 7, 2024 08:55
@SonnyBA SonnyBA self-assigned this Jun 7, 2024
Copy link
Contributor

@Coperh Coperh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep

@Coperh
Copy link
Contributor

Coperh commented Jun 7, 2024

Although, I wonder if its a similar situation here as mention in the comment: open-zaak/open-notificaties#155 (comment)

Can the part that shows he version be moved to open-api-framework

SonnyBA and others added 6 commits July 16, 2024 12:20
Note that this package should be removed whenever open-api-framework has a new release
Was previously used to pin `open-api-framework` with a git commit hash and thereby let CI pass
@SonnyBA SonnyBA force-pushed the feature/#21-show-version-admin branch from 80ca4e7 to dcddca1 Compare July 16, 2024 10:33
@SonnyBA SonnyBA merged commit a707c4f into master Jul 16, 2024
15 checks passed
@SonnyBA SonnyBA deleted the feature/#21-show-version-admin branch July 16, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show version of the release in the admin
2 participants