🔧 [maykinmedia/open-api-framework#40] Remove sites dependency #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to ensure that we no longer rely on in when generating the label for 2FA
6 tasks
annashamray
reviewed
Aug 19, 2024
There was a problem hiding this comment.
So you decided to keep sites in OAF and remove it in APIs themselves?
Afaik all our API admins have 2FA now, therefore they all suffer from the same problem.
We include 2fa in OAF, so it would be logical to fix the problem and removed Sites from OAF settings, I think
|
Btw I haven't noticed notification sending in Open Klant so I think it would be safe to remove Sites here |
6 tasks
|
@annashamray from the discussion we had on tuesday about this, I think removing sites per project (where possible) is the way to go for now right? maykinmedia/open-api-framework#40 (comment) |
|
Yes, let's for it this way |
annashamray
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes maykinmedia/open-api-framework#40 partially
Changes