-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 [#43] Update documentation for setup-configuration #47
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #47 +/- ##
=======================================
Coverage 92.45% 92.45%
=======================================
Files 54 54
Lines 1047 1047
=======================================
Hits 968 968
Misses 79 79 ☔ View full report in Codecov by Sentry. |
b72e2ca
to
889d3a2
Compare
setup_configuraiton | ||
setup_configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Misspelled it lol
.. warning:: This command is declarative - if configuration is manually changed after | ||
running the command and you then run the exact same command again, the manual | ||
changes will be reverted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this warning be added back in?
Would that need to be in setup config itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The warning is part of the general docs that are linked to: https://django-setup-configuration.readthedocs.io/en/0.7.0/quickstart.html#command-usage
to use directive provided by the library
889d3a2
to
ce9f42f
Compare
Fixes #43
Changes
Built docs can be viewed at: https://referentielijsten-api--47.org.readthedocs.build/en/47/installation/setup_configuration.html