Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/OIDC #7

Merged
merged 3 commits into from
May 30, 2024
Merged

Feature/OIDC #7

merged 3 commits into from
May 30, 2024

Conversation

bart-maykin
Copy link
Collaborator

fixes #3

@bart-maykin bart-maykin changed the base branch from master to feature/basic-api May 14, 2024 05:05
@bart-maykin bart-maykin requested a review from annashamray May 14, 2024 13:12
@bart-maykin bart-maykin changed the base branch from feature/basic-api to master May 14, 2024 13:21
@annashamray annashamray requested review from Coperh and stevenbal and removed request for annashamray May 16, 2024 12:27
Copy link
Collaborator

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently logging in with OIDC doesn't work, because the following line is missing from the AUTHENTICATION_BACKENDS:

"mozilla_django_oidc_db.backends.OIDCAuthenticationBackend",

Please make sure to test it locally if it works, in the repo of mozilla-django-oidc-db there is a docker compose setup you can use to run Keycloak as an identity provider: https://github.com/maykinmedia/mozilla-django-oidc-db/tree/master/docker

If you get that container running and set the following settings in the Referentielijsten admin (OIDC config), it should be possible to test this locally:

image

@stevenbal
Copy link
Collaborator

Also I see that the tests in CI seem to be skipped, so there's probably something going wrong in the GH actions setup?

image

Copy link
Contributor

@Coperh Coperh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the things Steven caught (which I probably would not have), looks good.

Appears on the login page and styling works.

@stevenbal stevenbal merged commit 7a9d574 into master May 30, 2024
11 checks passed
@stevenbal stevenbal deleted the feature/oidc branch May 30, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OIDC?
3 participants