Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACAS-727: Update to nodejs 20 LTS #1155

Merged
merged 1 commit into from
Apr 29, 2024
Merged

ACAS-727: Update to nodejs 20 LTS #1155

merged 1 commit into from
Apr 29, 2024

Conversation

brianbolt
Copy link
Contributor

@brianbolt brianbolt commented Apr 18, 2024 •
edited
Loading

Description

Related Issue

ACAS-727

How Has This Been Tested?

Ran acasclient tests after building all 3 branches of ACAS-727 locally
Poked around the UI and loaded all module menus, verified drop downs worked.

This was referenced Apr 18, 2024
Merged
Merged
bffrost
bffrost approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@bffrost bffrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, great that this is so easy. I checked on the ACAS-762 issue mentioned below but it seems node 20 doesn't yet have the patched version of npm, so I think the workaround needs to stay for a little longer.

@brianbolt brianbolt merged commit 2dd4eb2 into release/2024.2.x Apr 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bffrost bffrost bffrost approved these changes

@dalejerikson dalejerikson dalejerikson approved these changes

@hhan-schrodinger hhan-schrodinger Awaiting requested review from hhan-schrodinger

Assignees
No one assigned
Labels
upmerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brianbolt @bffrost @dalejerikson