Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACAS-734: Scope experiment table controller to this #1178

Merged
merged 1 commit into from
Jun 17, 2024
Merged

ACAS-734: Scope experiment table controller to this #1178

merged 1 commit into from
Jun 17, 2024

Conversation

brianbolt
Copy link
Contributor

@brianbolt brianbolt commented Jun 17, 2024 •
edited
Loading

Description

  • Fixes bug where clicking on rows in Experiment Browser an then rows in Protocol Browser with endpoint manager turned on would produce and alert Cannot reinitialise DataTable.
Screenshot 2024-06-17 at 4 10 44 PM

Related Issue

ACAS-734

How Has This Been Tested?

  • Reliably reproduced the problem by:
    • Searching for an experiment in Experiment Browser and clicking a row
    • Searching for a protocol in Protocol Browser and clicking a row
  • Verified the alert went away using the same test
  • Verified manually that both Protocol Browser and Experiment Browser functioned normally after the change.

bffrost
bffrost approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@bffrost bffrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianbolt brianbolt merged commit 43e8a19 into release/2024.2.x Jun 17, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bffrost bffrost bffrost approved these changes

@hhan-schrodinger hhan-schrodinger Awaiting requested review from hhan-schrodinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianbolt @bffrost