Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACAS-784: Lookup qtLoader.module #1184

Closed
wants to merge 2 commits into from
Closed

ACAS-784: Lookup qtLoader.module #1184

wants to merge 2 commits into from

Conversation

brianbolt
Copy link
Contributor

@brianbolt brianbolt commented Jun 27, 2024 •
edited
Loading

Description

  • In 2024-3 QTLoader was updated in MaestroSketcher and way to access it has changed.

Related Issue

ACAS-784

How Has This Been Tested?

  • Currently this PR has 2 commits. I tested the first commit on a 2024-2 instance to verify that the ? operator change works was expected. I have not tested the second commit as the change to access maestro via qtLoader.module is pending.

@brianbolt brianbolt requested a review from bffrost June 27, 2024 18:58
@bffrost
Copy link
Collaborator

bffrost commented Aug 12, 2024

@brianbolt I'd like to close this in favor of https://github.com/schrodinger/acas_custom_schrodinger/pull/130 but let me know if you disagree

@brianbolt
Copy link
Contributor Author

Yep. Closing now.

@brianbolt brianbolt closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bffrost bffrost Awaiting requested review from bffrost

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianbolt @bffrost