Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACAS-802: Air gapped ACAS cannot install LDClient dependencies #1185

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

brianbolt
Copy link
Contributor

@brianbolt brianbolt commented Sep 26, 2024

Description

  • Adds ldclient python requirements to ACAS base image

Related Issue

ACAS-802

How Has This Been Tested?

Verified image builds and that I could install ldclient without installing dependencies:

Defaulting to user installation because normal site-packages is not writeable
Collecting https://redacted.com/livedesign/ldclient.tar.gz
  Downloading https://redcated.com/livedesign/ldclient.tar.gz (133 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 133.9/133.9 kB 718.2 kB/s eta 0:00:00
  Preparing metadata (setup.py) ... done
Requirement already satisfied: requests<3.0.0,>=2.0.0 in /usr/local/lib/python3.11/site-packages (from ldclient==2024.4.2.dev0) (2.32.3)
Requirement already satisfied: Deprecated==1.2.10 in /usr/local/lib/python3.11/site-packages (from ldclient==2024.4.2.dev0) (1.2.10)
Requirement already satisfied: wrapt<2,>=1.10 in /usr/local/lib64/python3.11/site-packages (from Deprecated==1.2.10->ldclient==2024.4.2.dev0) (1.16.0)
Requirement already satisfied: charset-normalizer<4,>=2 in /usr/local/lib64/python3.11/site-packages (from requests<3.0.0,>=2.0.0->ldclient==2024.4.2.dev0) (3.3.2)
Requirement already satisfied: idna<4,>=2.5 in /usr/local/lib/python3.11/site-packages (from requests<3.0.0,>=2.0.0->ldclient==2024.4.2.dev0) (3.10)
Requirement already satisfied: urllib3<3,>=1.21.1 in /usr/local/lib/python3.11/site-packages (from requests<3.0.0,>=2.0.0->ldclient==2024.4.2.dev0) (2.2.3)
Requirement already satisfied: certifi>=2017.4.17 in /usr/local/lib/python3.11/site-packages (from requests<3.0.0,>=2.0.0->ldclient==2024.4.2.dev0) (2024.8.30)
Installing collected packages: ldclient
  Attempting uninstall: ldclient
    Found existing installation: ldclient 2024.3.3.dev0
    Uninstalling ldclient-2024.3.3.dev0:
      Successfully uninstalled ldclient-2024.3.3.dev0
  DEPRECATION: ldclient is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option. Discussion can be found at https://github.com/pypa/pip/issues/8559
  Running setup.py install for ldclient ... done
Successfully installed ldclient-2024.4.2.dev0

@brianbolt brianbolt changed the title ACAS-802: Air gapped ACAS cannot install LDClient depedencies ACAS-802: Air gapped ACAS cannot install LDClient dependencies Sep 26, 2024
@brianbolt brianbolt changed the base branch from release/2024.4.x to release/2024.1.x September 26, 2024 19:32
@brianbolt brianbolt changed the base branch from release/2024.1.x to release/2024.4.x September 26, 2024 19:32
Copy link
Collaborator

@bffrost bffrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@brianbolt brianbolt changed the base branch from release/2024.4.x to release/2024.3.x September 27, 2024 11:13
@brianbolt
Copy link
Contributor Author

Switching this back to the 2024.3.x release before merging to get this into an earlier version just in case. I re-ran the same tests and it worked the same.

@brianbolt brianbolt merged commit 2168431 into release/2024.3.x Sep 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants