-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACAS-834: Provide appropriate inputs for bulk loader default values #1203
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Looks nice! :)
I see what you mean when playing around with the project select list. Typing doesn't seem to change anything and is basically broken. In my testing, getting this if block to return false does the trick:
So I think it would be as easy as adding an option that skips the select2Options.ajax function creation if provided. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a small nit but I do think its worth adding the fix for the select2 widget type ahead so I'm requesting changes.
Thanks for this @brianbolt . I've added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice LGTM
Description
The original ticket was narrowly scoped to provide a date picker when entering the lot date synthesized. I did that, and then extended it to also provide dropdowns for any fields that have constrained possible values / data dictionaries.
Related Issue
https://schrodinger.atlassian.net/browse/ACAS-834
How Has This Been Tested?
Tested locally:
Screenshots / Videos
Dropdown:

Date picker:

Known Issues