Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACAS-760: Added experiment loader warning test for numerics in Numbers that will be saved as Text #162

Merged
merged 1 commit into from
Apr 30, 2024
Merged

ACAS-760: Added experiment loader warning test for numerics in Numbers that will be saved as Text #162

merged 1 commit into from
Apr 30, 2024

Conversation

brianbolt
Copy link
Contributor

@brianbolt brianbolt commented Apr 18, 2024 •
edited
Loading

Description

Related Issue

ACAS-760

How Has This Been Tested?

Ran acasclient tests.

@brianbolt brianbolt mentioned this pull request Apr 18, 2024
Merged
dalejerikson
dalejerikson approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@dalejerikson dalejerikson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

bffrost
bffrost approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@bffrost bffrost left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test LGTM, but please make sure it passes after you merge the associated ACAS change before merging this PR.

@brianbolt brianbolt merged commit 5cd1757 into release/2024.2.x Apr 30, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bffrost bffrost bffrost approved these changes

@dalejerikson dalejerikson dalejerikson approved these changes

@hhan-schrodinger hhan-schrodinger Awaiting requested review from hhan-schrodinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brianbolt @bffrost @dalejerikson