Fix: bump test timeouts: 200ms -> 500ms

200ms allows for some flakiness. Most things will still finish faster. If the
event doesn't happen in 500ms, that's probably interesting, finally.

Author: coreyti

test/integration/locator_test.exs

@@ -40,7 +40,7 @@ defmodule Playwright.LocatorTest do
 
   describe "Locator.check/2" do
     setup(%{assets: assets, page: page}) do
-      options = %{timeout: 200}
+      options = %{timeout: 500}
 
       page |> Page.goto(assets.prefix <> "/empty.html")
       page |> Page.set_content("<input id='checkbox' type='checkbox'/>")
@@ -59,13 +59,13 @@ defmodule Playwright.LocatorTest do
       frame = Page.main_frame(page)
 
       locator = Locator.new(frame, "input#bogus")
-      assert {:error, %Error{message: "Timeout 200ms exceeded."}} = Locator.check(locator, options)
+      assert {:error, %Error{message: "Timeout 500ms exceeded."}} = Locator.check(locator, options)
     end
   end
 
   describe "Locator.click/2" do
     setup(%{assets: assets, page: page}) do
-      options = %{timeout: 200}
+      options = %{timeout: 500}
 
       page |> Page.goto(assets.prefix <> "/empty.html")
       page |> Page.set_content("<a id='link' target=_blank rel=noopener href='/one-style.html'>yo</a>")
@@ -84,14 +84,14 @@ defmodule Playwright.LocatorTest do
       frame = Page.main_frame(page)
 
       locator = Locator.new(frame, "a#bogus")
-      assert {:error, %Error{message: "Timeout 200ms exceeded."}} = Locator.click(locator, options)
+      assert {:error, %Error{message: "Timeout 500ms exceeded."}} = Locator.click(locator, options)
     end
 
     test "clicking a button", %{assets: assets, page: page} do
       locator = Page.locator(page, "button")
       page |> Page.goto(assets.prefix <> "/input/button.html")
 
-      Locator.click(locator, %{timeout: 200})
+      Locator.click(locator, %{timeout: 500})
       assert Page.evaluate(page, "window['result']") == "Clicked"
     end
   end
@@ -112,7 +112,7 @@ defmodule Playwright.LocatorTest do
       }
       """)
 
-      Locator.dblclick(locator, %{timeout: 200})
+      Locator.dblclick(locator, %{timeout: 500})
       assert Page.evaluate(page, "window['double']") == true
       assert Page.evaluate(page, "window['result']") == "Clicked"
     end
@@ -694,7 +694,7 @@ defmodule Playwright.LocatorTest do
 
   describe "Locator.uncheck/2" do
     setup(%{assets: assets, page: page}) do
-      options = %{timeout: 200}
+      options = %{timeout: 500}
 
       page |> Page.goto(assets.prefix <> "/empty.html")
       page |> Page.set_content("<input id='checkbox' type='checkbox' checked/>")
@@ -712,13 +712,13 @@ defmodule Playwright.LocatorTest do
 
     test "returns a timeout error when unable to 'uncheck'", %{options: options, page: page} do
       locator = Page.locator(page, "input#bogus")
-      assert {:error, %Error{message: "Timeout 200ms exceeded."}} = Locator.uncheck(locator, options)
+      assert {:error, %Error{message: "Timeout 500ms exceeded."}} = Locator.uncheck(locator, options)
     end
   end
 
   describe "Locator.wait_for/2" do
     setup(%{assets: assets, page: page}) do
-      options = %{timeout: 200}
+      options = %{timeout: 500}
 
       page |> Page.goto(assets.prefix <> "/empty.html")
 

test/integration/page/expect_test.exs

@@ -37,10 +37,10 @@ defmodule Playwright.Page.NetworkTest do
     test "w/ an event and a timeout", %{page: page} do
       {:error, %Error{message: message}} =
         Page.expect_event(page, :request_finished, %{
-          timeout: 200
+          timeout: 500
         })
 
-      assert message == "Timeout 200ms exceeded."
+      assert message == "Timeout 500ms exceeded."
     end
 
     test "w/ an event, a (truthy) predicate, and a timeout", %{assets: assets, page: page} do
@@ -51,7 +51,7 @@ defmodule Playwright.Page.NetworkTest do
           predicate: fn _, _ ->
             true
           end,
-          timeout: 200
+          timeout: 500
         })
 
       assert event.type == :request_finished
@@ -65,10 +65,10 @@ defmodule Playwright.Page.NetworkTest do
           predicate: fn _, _ ->
             false
           end,
-          timeout: 200
+          timeout: 500
         })
 
-      assert message == "Timeout 200ms exceeded."
+      assert message == "Timeout 500ms exceeded."
     end
   end
 
@@ -115,14 +115,14 @@ defmodule Playwright.Page.NetworkTest do
             predicate: fn _, _ ->
               false
             end,
-            timeout: 200
+            timeout: 500
           },
           fn ->
             Page.goto(page, assets.empty)
           end
         )
 
-      assert message == "Timeout 200ms exceeded."
+      assert message == "Timeout 500ms exceeded."
     end
 
     test "w/ an event and a timeout", %{assets: assets, page: page} do
@@ -131,7 +131,7 @@ defmodule Playwright.Page.NetworkTest do
           page,
           :request_finished,
           %{
-            timeout: 200
+            timeout: 500
           },
           fn ->
             Page.goto(page, assets.empty)

test/integration/page_test.exs

@@ -220,8 +220,8 @@ defmodule Playwright.PageTest do
     test "with a single option given mismatched attributes, returns a timeout", %{assets: assets, page: page} do
       page |> Page.goto(assets.prefix <> "/input/select.html")
 
-      assert {:error, %Error{message: "Timeout 200ms exceeded."}} =
-               Page.select_option(page, "select", %{value: "green", label: "Brown"}, %{timeout: 200})
+      assert {:error, %Error{message: "Timeout 500ms exceeded."}} =
+               Page.select_option(page, "select", %{value: "green", label: "Brown"}, %{timeout: 500})
     end
 
     test "with multiple options and a single-option select, selects the first", %{assets: assets, page: page} do
@@ -342,7 +342,7 @@ defmodule Playwright.PageTest do
       assert page |> Page.get_attribute("div#outer", "name") == "value"
       assert page |> Page.get_attribute("div#outer", "foo") == nil
 
-      assert({:error, %Error{}} = Page.get_attribute(page, "glorp", "foo", %{timeout: 200}))
+      assert({:error, %Error{}} = Page.get_attribute(page, "glorp", "foo", %{timeout: 500}))
     end
   end