Fixes Locator.wait_for support for waiting for hidden state elements

Author: ry4n1m3

lib/playwright/locator.ex

@@ -1325,11 +1325,11 @@ defmodule Playwright.Locator do
   @spec wait_for(t(), options()) :: t() | {:error, Channel.Error.t()}
   def wait_for(%Locator{} = locator, options \\ %{}) do
     case Frame.wait_for_selector(locator.frame, locator.selector, options) do
-      %ElementHandle{} ->
-        locator
-
       {:error, _} = error ->
         error
+
+      _ ->
+        locator
     end
   end
 

test/api/locator_test.exs

@@ -815,6 +815,22 @@ defmodule Playwright.LocatorTest do
       assert [:ok, %Locator{}] = Task.await_many([setup, check])
     end
 
+    test "on success with nil return (i.e., a match is found in time) returns the `Locator` instance", %{page: page} do
+      locator = Locator.new(page, "div > span")
+
+      setup =
+        Task.async(fn ->
+          Page.set_content(page, "<div><span style='visibility: hidden;'>target</span></div>")
+        end)
+
+      check =
+        Task.async(fn ->
+          Locator.wait_for(locator, %{timeout: 100, state: "hidden"})
+        end)
+
+      assert [:ok, %Locator{}] = Task.await_many([setup, check])
+    end
+
     test "on failure (i.e., the timeout is reached) returns an `{:error, error}` tuple", %{page: page} do
       locator = Locator.new(page, "div > span")