[Fixed] Resolves a number of test issues

coreyti · coreyti · commit d648eff05d41 · 2024-05-30T11:25:14.000-07:00
Some of which stem from internal changes, some from changes to playwright-core.
diff --git a/lib/playwright/browser_context.ex b/lib/playwright/browser_context.ex
@@ -352,6 +352,9 @@ defmodule Playwright.BrowserContext do
       {:ok, _} ->
         :ok
 
+      {:ok, _} ->
+        :ok
+
       {:error, %Channel.Error{message: "Target page, context or browser has been closed"}} ->
         :ok
     end
diff --git a/lib/playwright/sdk/channel_owner.ex b/lib/playwright/sdk/channel_owner.ex
@@ -12,7 +12,6 @@ defmodule Playwright.SDK.ChannelOwner do
       @derive {Inspect, only: [:guid] ++ @properties}
 
       import Playwright.SDK.Extra.Map
-      alias Playwright.SDK.Channel.Event
       alias Playwright.SDK.Channel
 
       defstruct @properties ++ [:session, :guid, :initializer, :listeners, :parent, :type]
@@ -80,8 +79,8 @@ defmodule Playwright.SDK.ChannelOwner do
       require Logger
 
       @doc false
-      @spec on_event(struct(), Event.t()) :: {term(), struct()}
-      def on_event(owner, %Event{} = event) do
+      @spec on_event(struct(), Channel.Event.t()) :: {term(), struct()}
+      def on_event(owner, %Channel.Event{} = event) do
         listeners = Map.get(owner.listeners, event.type, [])
 
         event =
diff --git a/lib/playwright/sdk/helpers/serialization.ex b/lib/playwright/sdk/helpers/serialization.ex
@@ -4,10 +4,15 @@ defmodule Playwright.SDK.Helpers.Serialization do
   import Playwright.SDK.Extra.Map
 
   def deserialize(:ok) do
-    # Logger.warning("Received `Playwright.SDK.Helpers.Serialization.deserialize/1` with `:ok`. It's unclear why this is happening")
+    Logger.warning("Received `Playwright.SDK.Helpers.Serialization.deserialize/1` with `:ok`. It's unclear why this is happening")
     :ok
   end
 
+  # NOTE: this is (probably) the desired API; need to work toward it.
+  def deserialize({:ok, value}) do
+    deserialize(value)
+  end
+
   def deserialize(value) when is_map(value) do
     case value do
       %{a: list} ->
diff --git a/test/integration/page/accessibility_test.exs b/test/integration/page/accessibility_test.exs
@@ -135,7 +135,7 @@ defmodule Playwright.Page.AccessibilityTest do
                value: "Edit this image:",
                children: [
                  %{role: "text", name: "Edit this image:"},
-                 %{role: "img", name: "my fake image"}
+                 %{role: "image", name: "my fake image"}
                ]
              }
     end
@@ -155,7 +155,8 @@ defmodule Playwright.Page.AccessibilityTest do
                multiline: true,
                value: "Edit this image:",
                children: [
-                 %{role: "text", name: "Edit this image:"}
+                 %{role: "text", name: "Edit this image:"},
+                 %{role: "image", name: "my fake image"}
                ]
              }
     end
diff --git a/test/integration/page/evaluate_handle_test.exs b/test/integration/page/evaluate_handle_test.exs
@@ -35,6 +35,7 @@ defmodule Playwright.Page.EvaluateHandleTest do
 
     test "works with a handle that references an object with nesting", %{page: page} do
       handle = Page.evaluate_handle(page, "function() { return { x: 1, y: { lala: 'lulu' } }; }")
+      assert %Playwright.JSHandle{} = handle
       assert Page.evaluate(page, "function(o) { return o; }", handle) == %{x: 1, y: %{lala: "lulu"}}
     end
 
diff --git a/test/integration/response_test.exs b/test/integration/response_test.exs
@@ -14,7 +14,7 @@ defmodule Playwright.ResponseTest do
   describe "Response.body/1" do
     test "for a simple HTML page", %{assets: assets, page: page} do
       response = Page.goto(page, assets.prefix <> "/title.html")
-      assert Response.body(response) == "<title>Woof-Woof</title>\n"
+      assert Response.body(response) == "<!DOCTYPE html>\n<title>Woof-Woof</title>\n"
     end
   end
 end

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ defmodule Playwright.Page.AccessibilityTest do`
`135`	`135`	`value: "Edit this image:",`
`136`	`136`	`children: [`
`137`	`137`	`%{role: "text", name: "Edit this image:"},`
`138`		`- %{role: "img", name: "my fake image"}`
	`138`	`+ %{role: "image", name: "my fake image"}`
`139`	`139`	`]`
`140`	`140`	`}`
`141`	`141`	`end`
`@@ -155,7 +155,8 @@ defmodule Playwright.Page.AccessibilityTest do`
`155`	`155`	`multiline: true,`
`156`	`156`	`value: "Edit this image:",`
`157`	`157`	`children: [`
`158`		`- %{role: "text", name: "Edit this image:"}`
	`158`	`+ %{role: "text", name: "Edit this image:"},`
	`159`	`+ %{role: "image", name: "my fake image"}`
`159`	`160`	`]`
`160`	`161`	`}`
`161`	`162`	`end`