Skip to content

document env variables in CLI reference #1719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Omar8345
Copy link

document all (as I believe) environment variables for screenpipe CLI in CLI reference documentation

/claim #1298

Copy link
Contributor

🧪 testing bounty created!

a testing bounty has been created for this PR: view testing issue

testers will be awarded $20 each for providing quality test reports. please check the issue for testing requirements.

@divanshu-go
Copy link
Contributor

@Omar8345 as already said by @neo773
in the following comment #1447 (comment)

This is not the Right Approach !

as it creates future maintenance burden, instead we should consolidate all the envs in a crate and reference it, then you can run codegen on the env.rs file to generate a markdown file.

@divanshu-go
Copy link
Contributor

You can ask @neo773 cause its his Idea

@Omar8345
Copy link
Author

@divanshu-go maybe leave your suggestions

@neo773
Copy link
Contributor

neo773 commented Apr 12, 2025

Feel free to work on this PR

@Omar8345
Copy link
Author

Omar8345 commented Apr 12, 2025

Feel free to work on this PR

@neo773 I made a commit you saw that? Maybe you can leave a comment if its good or need changes

#ca6001e

@divanshu-go
Copy link
Contributor

image

@Omar8345 Please resolve this mistake

You have changed the permissions of these 2 files from executable --> non-executable

please remove them from your PR as soon as possible

chmod 755 screenpipe-vision/bin/ui_monitor
chmod 755 screenpipe-vision/bin/ui_monitor-aarch64-apple-darwin

and then commit them

@Omar8345
Copy link
Author

@divanshu-go done

@divanshu-go
Copy link
Contributor

@Omar8345 Also please Generate the Docs if your code can do that.

@Omar8345
Copy link
Author

@Omar8345 Also please Generate the Docs if your code can do that.

@divanshu-go just run it like by cd to the folder screenpipe-cli-envs and run the code, it'll populate the mdx file if you read the logic

@divanshu-go
Copy link
Contributor

divanshu-go commented Apr 12, 2025

@Omar8345 I'm just asking you to generate the docs and commit them.

@Omar8345
Copy link
Author

@divanshu-go All good, just one question, CUSTOM_DEEPGRAM_API_KEY and CUSTOM_DEEPGRAM_API_TOKEN could you explain the use of those environment variables so I can document them or is that not needed because I usually see them used in tests?

@divanshu-go
Copy link
Contributor

divanshu-go commented Apr 12, 2025

@Omar8345 CUSTOM_DEEPGRAM_API_TOKEN is used in screenpipe/screenpipe-audio/src/transcription/deepgram/mod.rs so you should document it.

while CUSTOM_DEEPGRAM_API_KEY can be dropped as it is used in test only , screenpipe/screenpipe-audio/tests/realtime_test.rs so there is no reason to document it.

@divanshu-go
Copy link
Contributor

@Omar8345 You changed the formatting of screenpipe-app-tauri/tsconfig.json
Please fix it.

@Omar8345
Copy link
Author

@Omar8345 You changed the formatting of screenpipe-app-tauri/tsconfig.json Please fix it.

oh god my prettifier thingy lmao

@Omar8345
Copy link
Author

@divanshu-go CUSTOM_DEEPGRAM_API_TOKEN this is optional, only required when using Deepgram for live transcription uhm?

@divanshu-go
Copy link
Contributor

@Omar8345 yes !

@Omar8345
Copy link
Author

Omar8345 commented Apr 12, 2025

@divanshu-go done ❤️ - sorry for the trouble as I'm not used to OSS contributing because I rarely do so & I'm new to screenpipe, love the software tho

also do you have any idea if payouts to PayPal is possible since Algora needs Stripe & I don't have it - please confirm with me before proceeding with bounty

@Omar8345
Copy link
Author

@divanshu-go please let me know if there's something more

@Omar8345
Copy link
Author

Omar8345 commented Apr 12, 2025

@divanshu-go Fixed it, I used a comment in MDX ({/* ENVIRONMENT VARIABLES WILL AUTOMATICALLY POPULATE HERE */}) which will surround the populated text so it knows where to replace the new text. I tested it and it's good.

@divanshu-go
Copy link
Contributor

@Omar8345 Why are doing this again and again ?
image

@Omar8345
Copy link
Author

Omar8345 commented Apr 12, 2025

@divanshu-go I believed I fixed it, here again

now its confirmed to be fixed

@Omar8345
Copy link
Author

Omar8345 commented Apr 14, 2025

@divanshu-go @louis030195 please update

@divanshu-go
Copy link
Contributor

divanshu-go commented Apr 14, 2025

Hi @Omar8345,
Kindly avoid repeatedly pinging us. @louis030195 will review your PR when he has the time.

Please understand that reviews can't be rushed or forced — we appreciate your patience.
Also, I've already contributed several reviews to this PR.

@Omar8345
Copy link
Author

@louis030195 Please update.

@Omar8345
Copy link
Author

can I have some estimate please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants