Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable SQL checks in Sonar #178

Merged
merged 3 commits into from
Oct 14, 2024
Merged

chore: enable SQL checks in Sonar #178

merged 3 commits into from
Oct 14, 2024

Conversation

andrablaj
Copy link
Member

Description

SQL checks in Sonar were disabled for this repo. As it contains mostly SQL code, re-enable SQL checks in Sonar.

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@andrablaj andrablaj marked this pull request as draft October 10, 2024 15:59
@andrablaj andrablaj marked this pull request as ready for review October 10, 2024 16:27
@andrablaj andrablaj requested a review from njuguna-n October 10, 2024 16:27
@andrablaj andrablaj self-assigned this Oct 10, 2024
Copy link
Contributor

@njuguna-n njuguna-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. One question though, is it possible to run an analysis on existing code before merging this? The SQL code in this repo also makes use of Jinja templating and wondering if Sonar will handle this correctly. I have checked out this branch and run Sonar lint locally through the VSCode plugin no issues but just want to be sure Sonar Cloud will be the same.

@andrablaj
Copy link
Member Author

andrablaj commented Oct 14, 2024

I forked the repo last week and merged this commit on the fork, and Sonar didn't raise any issues, so in the state the code it's now, it should pass the quality gate. We can always tweak the Sonar rules in the future if we start getting false positives.

Copy link
Contributor

@njuguna-n njuguna-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@andrablaj andrablaj merged commit af1cf8d into main Oct 14, 2024
4 checks passed
@andrablaj andrablaj deleted the enable-sonar-sql branch October 14, 2024 09:58
@medic-ci
Copy link

medic-ci commented Dec 6, 2024

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants