chore(#253): add descriptive login error messages #254
+129
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kennsippell I thought of different ways to design the solution and came up with this. Please share your thoughts of it. |
|
Tested this today with uasingishu instance. The login fails due to cert errors. I'm seeing the response hang and no error message ever appear. |
kennsippell
approved these changes
Feb 18, 2025
| return new AuthError('Missing username or password'); | ||
| } | ||
|
|
||
| static TOKEN_CREATION_FAILED(username: string, domain: string) { |
There was a problem hiding this comment.
Can we add scenario where instance is offline? This is quite a common scenario
There was a problem hiding this comment.
Sure.
I'm thinking we could use it in createSessionToken by checking if (e.code === 'ENOTFOUND') ? would that be sufficient to know the instance is offline ? @kennsippell
Benmuiruri
force-pushed
the
253-descriptie-error-msgs
branch
from
d9ca2d5 to
4188d7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes login error messages more descriptive.
Closes #253