Add types as dependencies.

[ksaaskil]

• Fixes the issue where RequestResponseSpy is typed as any because types from sinon are not included in the npm package EDIT: sinon types were added as dependencies in Add @types/sinon to unmock-core. #203 so this can be a separate PR
• See the discussion in @types/sinon and other dependant types should be included as dependencies #186

[codecov-io]

Codecov Report

Merging #201 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #201   +/-   ##
=======================================
  Coverage   88.81%   88.81%           
=======================================
  Files          48       48           
  Lines        1529     1529           
  Branches      357      357           
=======================================
  Hits         1358     1358           
  Misses        171      171

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d448ff...c4d39ae. Read the comment docs.

[idantene]

Sorry for the late reply, didn't see this!
LGTM, although I was under the impression that type dependencies (whether dev or not) should be at the top-most lerna level?

[ksaaskil]

But if they're in the lerna level, then individual packages do not include their own type dependencies I assume? Or they include the type dependencies of all packages? Neither of those sounds right to me 🤔

[idantene]

Fair points. Maybe it's just the dev dependencies then.

[mikesol]

Hey! Just wanted to see what the status of this is. Alive? Dead?

[ksaaskil]

Waiting for the final approval and fixing looots of conflicts, probably easier to just start over as so many dependencies have come and gone... Why so, is this causing trouble?

[ksaaskil]

So much has changed since this was implemented that it's easier to just start over.