Skip to content
This repository has been archived by the owner on Oct 30, 2022. It is now read-only.

Add @types/sinon to unmock-core. #203

Merged
merged 1 commit into from
Aug 30, 2019
Merged

Add @types/sinon to unmock-core. #203

merged 1 commit into from
Aug 30, 2019

Conversation

ksaaskil
Copy link
Contributor

@ksaaskil ksaaskil commented Aug 30, 2019

  • Quick fix while we think if we want to add all types as dependencies (Add types as dependencies. #201).
  • Sinon definitely needs to be a dependency because we even export that

@codecov-io
Copy link

Codecov Report

Merging #203 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #203   +/-   ##
=======================================
  Coverage   88.81%   88.81%           
=======================================
  Files          48       48           
  Lines        1529     1529           
  Branches      357      357           
=======================================
  Hits         1358     1358           
  Misses        171      171

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f2ba3f...a3d5c47. Read the comment docs.

@ksaaskil ksaaskil merged commit 8d448ff into dev Aug 30, 2019
@ksaaskil ksaaskil deleted the add-sinon-types branch August 30, 2019 08:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants