Skip to content

Commit 3fe30f8

Browse files
committed
Add namespace metadata option in templates
This sets the namespace key in metadata for all kubernetes manifests. The `.Release.Namespace` is a built-in variable in helm, that can be passed with` --namespace` on `install` or `template` step. If not set it defaults to `default`. *Why?* When using `helm install` with the `--namespace` argument the templates are applied into the chosen namespace. When using helm only as a template engine, in combination with GitOps tools like Flux, the namespace property must be set in the rendered manifests to be applied. For `--namespace` to have an effect when using `helm template`, it must be present like this in the templates. This change should not have any effect/change for `helm install` approach as far as I know.
1 parent d65dd8f commit 3fe30f8

9 files changed

+9
-0
lines changed

charts/meilisearch/templates/configmap.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ apiVersion: v1
22
kind: ConfigMap
33
metadata:
44
name: {{ include "meilisearch.fullname" . }}-environment
5+
namespace: {{ .Release.Namespace }}
56
labels:
67
{{- include "meilisearch.labels" . | nindent 4 }}
78
data:

charts/meilisearch/templates/ingress.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ apiVersion: extensions/v1beta1
1212
kind: Ingress
1313
metadata:
1414
name: {{ $fullName }}
15+
namespace: {{ .Release.Namespace }}
1516
labels:
1617
{{- include "meilisearch.labels" . | nindent 4 }}
1718
{{- with .Values.ingress.annotations }}

charts/meilisearch/templates/master-key-secret.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ apiVersion: v1
44
kind: Secret
55
metadata:
66
name: {{ template "secretMasterKeyName" . }}
7+
namespace: {{ .Release.Namespace }}
78
labels:
89
{{- include "meilisearch.labels" . | nindent 4 }}
910
data:

charts/meilisearch/templates/pvc.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ kind: PersistentVolumeClaim
44
apiVersion: v1
55
metadata:
66
name: {{ include "meilisearch.fullname" . }}
7+
namespace: {{ .Release.Namespace }}
78
labels:
89
{{- include "meilisearch.labels" . | nindent 4 }}
910
{{- with .Values.persistence.annotations }}

charts/meilisearch/templates/service.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ apiVersion: v1
22
kind: Service
33
metadata:
44
name: {{ include "meilisearch.fullname" . }}
5+
namespace: {{ .Release.Namespace }}
56
labels:
67
{{- include "meilisearch.labels" . | nindent 4 }}
78
{{- with .Values.service.annotations }}

charts/meilisearch/templates/serviceMonitor.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ apiVersion: monitoring.coreos.com/v1
33
kind: ServiceMonitor
44
metadata:
55
name: {{ include "meilisearch.fullname" . }}
6+
namespace: {{ .Release.Namespace }}
67
labels:
78
{{- include "meilisearch.labels" . | nindent 4 }}
89
{{- with .Values.serviceMonitor.additionalLabels }}

charts/meilisearch/templates/serviceaccount.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ apiVersion: v1
33
kind: ServiceAccount
44
metadata:
55
name: {{ template "meilisearch.fullname" . }}
6+
namespace: {{ .Release.Namespace }}
67
labels:
78
{{- include "meilisearch.labels" . | nindent 4 }}
89
{{- with .Values.serviceAccount.annotations }}

charts/meilisearch/templates/statefulset.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ apiVersion: apps/v1
22
kind: StatefulSet
33
metadata:
44
name: {{ include "meilisearch.fullname" . }}
5+
namespace: {{ .Release.Namespace }}
56
labels:
67
{{- include "meilisearch.labels" . | nindent 4 }}
78
spec:

charts/meilisearch/templates/tests/test-connection.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ apiVersion: v1
22
kind: Pod
33
metadata:
44
name: {{ include "meilisearch.fullname" . | lower }}-test-connection
5+
namespace: {{ .Release.Namespace }}
56
labels:
67
app.kubernetes.io/name: {{ include "meilisearch.name" . }}
78
helm.sh/chart: {{ include "meilisearch.chart" . }}

0 commit comments

Comments
 (0)