Skip to content

Commit 9da86e1

Browse files
bors[bot]eskombro
andauthored
Merge #54
54: Increase default health check delay values: InitialDelaySeconds for readinessProbe and livenessProbe r=eskombro a=eskombro By default, the values of `InitialDelaySeconds` for `readinessProbe` and `livenessProbe` were set to 0. `periodSeconds` was set to 10. 1. This means that the health checks are done as soon as the container starts running. If adding this health check is best practice, it is also good to let some time for the application to start running properly before doing the health check, since a bad response can be read by kubernetess cluster as a failure and it will restart the container. 2. A period of 10 seconds between every health check seems too short for most use-cases. A check every minute seems more appropriate as a default. These values are of course modifiable on the `values.yaml` file, but having more appropriate values seem better for most use-cases and for users who are not tuning these parameters. Co-authored-by: Samuel Jimenez <sjimenezre@gmail.com>
2 parents fb1869e + addc23d commit 9da86e1

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

charts/meilisearch/Chart.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v1
22
appVersion: "v0.19.0"
33
description: A Helm chart for the Meilisearch search engine
44
name: meilisearch
5-
version: 0.1.11
5+
version: 0.1.12
66
icon: https://res.cloudinary.com/meilisearch/image/upload/v1597822872/Logo/logo_img.svg
77
home: https://github.com/meilisearch/meilisearch-kubernetes/charts
88
maintainers:

charts/meilisearch/values.yaml

+4-4
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@
55
replicaCount: 1
66

77
readinessProbe:
8-
periodSeconds: 10
9-
InitialDelaySeconds: 0
8+
periodSeconds: 60
9+
InitialDelaySeconds: 60
1010

1111
livenessProbe:
12-
periodSeconds: 10
13-
InitialDelaySeconds: 0
12+
periodSeconds: 60
13+
InitialDelaySeconds: 60
1414

1515
image:
1616
repository: getmeili/meilisearch

0 commit comments

Comments
 (0)