Skip to content

Commit f57f155

Browse files
bors[bot]c0bra
andauthored
Merge #161
161: Document missing ingress.className value in README.md r=alallema a=c0bra # Pull Request ## What does this PR do? The README.md is missing documentation of the `ingress.className` value. If you mistakenly use an annotation like `kubernetes.io/ingress.class: nginx` you will get an error and scratch your head about how to address it. ## PR checklist Please check if your PR fulfills the following requirements: - [X] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [X] Have you read the contributing guidelines? - [X] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Brian Hann <c0bra@users.noreply.github.com>
2 parents 3fff54e + 5aa7be9 commit f57f155

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

charts/meilisearch/Chart.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v1
22
appVersion: "v1.0.0"
33
description: A Helm chart for the Meilisearch search engine
44
name: meilisearch
5-
version: 0.1.48
5+
version: 0.1.49
66
icon: https://res.cloudinary.com/meilisearch/image/upload/v1597822872/Logo/logo_img.svg
77
home: https://github.com/meilisearch/meilisearch-kubernetes/charts
88
maintainers:

charts/meilisearch/README.md

+2
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,8 @@ helm uninstall <your-service-name>
7474
| | |
7575
| `ingress.annotations` | Ingress annotations | `{}`
7676
| | |
77+
| `ingress.className` | Ingress ingressClassName | `nginx`
78+
| | |
7779
| `ingress.path` | Path within the host | `/`
7880
| | |
7981
| `ingress.hosts` | List of hostnames | `[meilisearch-example.local]`

0 commit comments

Comments
 (0)