This would cause a crash due to pre-alloc Pts for hooks

- This translation is not required in a 1:1 mapping but is done for demonstration purposes and in case changes are made to the Paging/EPT.

Author: memN0ps

hypervisor/src/intel/addresses.rs

@@ -84,9 +84,14 @@ impl PhysicalAddress {
         let (pml4_address, _, _) = Ept::decode_eptp(vmcs_eptp)?;
         trace!("EPT PML4 Address: {:#x}", pml4_address);
 
-        let host_pa = unsafe { Ept::translate_guest_pa_to_host_pa(pml4_address, guest_pa)? };
-        trace!("Guest PA: {:#x} -> Host PA: {:#x}", guest_pa, host_pa);
+        // Note: This may cause a crash at `!pt_entry.readable()` because the hypervisor has pre-allocated page tables
+        // in the hook_manager that are not passed to this function. We're attempting to translate a guest physical address to a host physical address using the EPT.
+        // The hypervisor maps everything as 2MB pages. The hooked pages are split and stored in the pre-allocated Pt,
+        // which are usually passed as a parameter, those are not stored in the EPT structure.
+        // This translation is not required in a 1:1 mapping but is done for demonstration purposes and in case changes are made to the Paging/EPT.
+        // let host_pa = unsafe { Ept::translate_guest_pa_to_host_pa(pml4_address, guest_pa)? };
+        // trace!("Guest PA: {:#x} -> Host PA: {:#x}", guest_pa, host_pa);
 
-        Ok(host_pa)
+        Ok(guest_pa)
     }
 }

hypervisor/src/intel/ept.rs

@@ -526,6 +526,7 @@ impl Ept {
     pub fn create_eptp_with_wb_and_4lvl_walk(&self) -> Result<u64, HypervisorError> {
         // Get the virtual address of the PML4 table for EPT.
         let addr = addr_of!(self.pml4) as u64;
+        trace!("EPT PML4 (self) address: {:#x}", addr);
 
         // Get the physical address of the PML4 table for EPT.
         let ept_pml4_base_addr = addr;