Skip to content

Commit 12c1273

Browse files
committed
Remove leftovers wip
1 parent 9e85059 commit 12c1273

File tree

5 files changed

+36
-53
lines changed

5 files changed

+36
-53
lines changed

benchmark/metric/in_progress_memory.ex

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ defmodule Benchmark.Metric.InProgressMemory do
1111

1212
if cumulative_memory > cumulative_memory_ref * (1 + @tolerance_factor),
1313
do:
14-
IO.warn(
14+
raise(
1515
"The memory performance has got worse! For test case: #{inspect(test_case, pretty: true)}
1616
the cumulative memory used to be: #{cumulative_memory_ref} MB and now it is: #{cumulative_memory} MB"
1717
)

benchmark/metric/message_queues_length.ex

+1-3
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ defmodule Benchmark.Metric.MessageQueuesLength do
44
@tolerance_factor 0.5
55
@sampling_period 100
66

7-
require Membrane.Logger
8-
97
@impl true
108
def assert(queues_lengths, queues_lengths_ref, test_case) do
119
cumulative_queues_length = integrate(queues_lengths)
@@ -14,7 +12,7 @@ defmodule Benchmark.Metric.MessageQueuesLength do
1412
if cumulative_queues_length >
1513
cumulative_queues_length_ref * (1 + @tolerance_factor),
1614
do:
17-
IO.warn(
15+
raise(
1816
"The cumulative queues length has got worse! For test case: #{inspect(test_case, pretty: true)}
1917
the cumulative queues length to be: #{cumulative_queues_length_ref} and now it is: #{cumulative_queues_length}"
2018
)

benchmark/metric/time.ex

+5-5
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@ defmodule Benchmark.Metric.Time do
55

66
@impl true
77
def assert(time, time_ref, test_case) do
8-
if time > time_ref * (1 + @tolerance_factor) do
9-
IO.warn(
10-
"The time performance has got worse! For test case: #{inspect(test_case, pretty: true)} the test
8+
if time > time_ref * (1 + @tolerance_factor),
9+
do:
10+
raise(
11+
"The time performance has got worse! For test case: #{inspect(test_case, pretty: true)} the test
1112
used to take: #{time_ref} ms and now it takes: #{time} ms"
12-
)
13-
end
13+
)
1414

1515
:ok
1616
end

benchmark/run.exs

+29-29
Original file line numberDiff line numberDiff line change
@@ -61,43 +61,43 @@ defmodule Benchmark.Run do
6161
require Membrane.Pad
6262

6363
@test_cases [
64-
# linear: [
65-
# reductions: 1_000,
66-
# max_random: 1,
67-
# number_of_filters: 10,
68-
# number_of_buffers: 500_000,
69-
# buffer_size: 1
70-
# ],
71-
# linear: [
72-
# reductions: 1_000,
73-
# max_random: 1,
74-
# number_of_filters: 100,
75-
# number_of_buffers: 50_000,
76-
# buffer_size: 1
77-
# ],
78-
# linear: [
79-
# reductions: 1_000,
80-
# max_random: 5,
81-
# number_of_filters: 10,
82-
# number_of_buffers: 50_000,
83-
# buffer_size: 1
84-
# ],
64+
linear: [
65+
reductions: 1_000,
66+
max_random: 1,
67+
number_of_filters: 10,
68+
number_of_buffers: 500_000,
69+
buffer_size: 1
70+
],
71+
linear: [
72+
reductions: 1_000,
73+
max_random: 1,
74+
number_of_filters: 100,
75+
number_of_buffers: 50_000,
76+
buffer_size: 1
77+
],
78+
linear: [
79+
reductions: 1_000,
80+
max_random: 5,
81+
number_of_filters: 10,
82+
number_of_buffers: 50_000,
83+
buffer_size: 1
84+
],
8585
with_branches: [
8686
struct: [{1, 3}, {3, 2}, {2, 1}],
8787
reductions: 100,
8888
number_of_buffers: 50_000,
8989
buffer_size: 1,
9090
max_random: 1
91-
# ],
92-
# with_branches: [
93-
# struct: [{1, 2}, {1, 2}, {2, 1}, {2, 1}],
94-
# reductions: 100,
95-
# number_of_buffers: 500_000,
96-
# buffer_size: 1,
97-
# max_random: 10
91+
],
92+
with_branches: [
93+
struct: [{1, 2}, {1, 2}, {2, 1}, {2, 1}],
94+
reductions: 100,
95+
number_of_buffers: 500_000,
96+
buffer_size: 1,
97+
max_random: 10
9898
]
9999
]
100-
@how_many_tries 10
100+
@how_many_tries 5
101101
# [ms]
102102
@test_timeout 300_000
103103
# the greater the factor is, the more unevenly distributed by the dispatcher will the buffers be

benchmark/run.sh

-15
This file was deleted.

0 commit comments

Comments
 (0)