Skip to content

Commit

Permalink
Remove unnecessary warning
Browse files Browse the repository at this point in the history
  • Loading branch information
FelonEkonom committed Feb 13, 2024
1 parent f4402ad commit 2fa7aba
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 16 deletions.
9 changes: 1 addition & 8 deletions lib/membrane/core/bin/action_handler.ex
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,7 @@ defmodule Membrane.Core.Bin.ActionHandler do
end

@impl CallbackHandler
def handle_action({:spec, spec}, cb, _params, state) do
if cb == :handle_spec_started do
Membrane.Logger.warning("""
Action :spec was returned from handle_spec_started/3 callback. It is suggested not to do this,
because it might lead to infinite loof of handle_spec_started/3 executions.
""")
end

def handle_action({:spec, spec}, _cb, _params, state) do
Parent.ChildLifeController.handle_spec(spec, state)
end

Expand Down
9 changes: 1 addition & 8 deletions lib/membrane/core/pipeline/action_handler.ex
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,7 @@ defmodule Membrane.Core.Pipeline.ActionHandler do
end

@impl CallbackHandler
def handle_action({:spec, spec}, cb, _params, state) do
if cb == :handle_spec_started do
Membrane.Logger.warning("""
Action :spec was returned from handle_spec_started/3 callback. It is suggested not to do this,
because it might lead to infinite loof of handle_spec_started/3 executions.
""")
end

def handle_action({:spec, spec}, _cb, _params, state) do
Parent.ChildLifeController.handle_spec(spec, state)
end

Expand Down

0 comments on commit 2fa7aba

Please sign in to comment.