Skip to content

Commit 393d2ba

Browse files
committed
Upgrade docs
1 parent 067780e commit 393d2ba

File tree

2 files changed

+17
-7
lines changed

2 files changed

+17
-7
lines changed

lib/membrane/timestamp_queue.ex

+11-2
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,11 @@ defmodule Membrane.TimestampQueue do
6363
pause_demand_boundary_unit: :buffers | :bytes
6464
]
6565

66+
@doc """
67+
Creates and returnes new #{inspect(__MODULE__)}.
68+
69+
Accepts `t:options()`.
70+
"""
6671
@spec new(options) :: t()
6772
def new(options \\ []) do
6873
metric =
@@ -76,8 +81,12 @@ defmodule Membrane.TimestampQueue do
7681
}
7782
end
7883

79-
@spec register_pad(t(), Pad.ref()) :: t()
80-
def register_pad(%__MODULE__{} = timestamp_queue, pad_ref) do
84+
@doc """
85+
Makes the queue not return any buffer in `pop_batch/3`, until a buffer or end of stream arrival
86+
from `pad_ref`.
87+
"""
88+
@spec wait_on_pad(t(), Pad.ref()) :: t()
89+
def wait_on_pad(%__MODULE__{} = timestamp_queue, pad_ref) do
8190
timestamp_queue
8291
|> Map.update!(:waiting_on_buffer_from, &MapSet.put(&1, pad_ref))
8392
end

test/membrane/timestamp_queue_test.exs

+6-5
Original file line numberDiff line numberDiff line change
@@ -305,8 +305,8 @@ defmodule Membrane.TimestampQueueTest do
305305
test "registering pads" do
306306
queue =
307307
TimestampQueue.new()
308-
|> TimestampQueue.register_pad(:a)
309-
|> TimestampQueue.register_pad(:b)
308+
|> TimestampQueue.wait_on_pad(:a)
309+
|> TimestampQueue.wait_on_pad(:b)
310310

311311
events = for i <- 1..1000, do: %Event{dts: i}
312312
buffers = for i <- 1..1000, do: %Buffer{dts: i, payload: <<>>}
@@ -346,9 +346,10 @@ defmodule Membrane.TimestampQueueTest do
346346
assert batch == sorted_batch
347347

348348
grouped_batch = Enum.group_by(batch, &elem(&1, 0), &(elem(&1, 1) |> elem(1)))
349+
349350
assert grouped_batch == %{
350-
a: List.delete_at(buffers, 999),
351-
b: List.delete_at(buffers, 999)
352-
}
351+
a: List.delete_at(buffers, 999),
352+
b: List.delete_at(buffers, 999)
353+
}
353354
end
354355
end

0 commit comments

Comments
 (0)