Impelement comments from CR

Author: FelonEkonom

lib/membrane/child_entry.ex

@@ -21,7 +21,7 @@ defmodule Membrane.ChildEntry do
           module: module,
           options: struct | nil,
           component_type: :element | :bin,
-          playback: Membrane.Playback.t(),
+          # playback: Membrane.Playback.t(),
           pid: pid,
           clock: Membrane.Clock.t(),
           sync: Membrane.Sync.t(),
@@ -41,7 +41,7 @@ defmodule Membrane.ChildEntry do
     :group,
     initialized?: false,
     ready?: false,
-    terminating?: false,
-    playback: :stopped
+    terminating?: false
+    # playback: :stopped
   ]
 end

lib/membrane/core/parent/child_life_controller.ex

@@ -403,24 +403,15 @@ defmodule Membrane.Core.Parent.ChildLifeController do
   defp do_proceed_spec_startup(_spec_ref, %{status: :ready} = spec_data, state) do
     state =
       Enum.reduce(spec_data.children_names, state, fn child, state ->
-        child_entry = get_in(state, [:children, child])
+        %{pid: pid, terminating?: terminating?} = state.children[child]
 
-        child_entry =
-          case child_entry do
-            %{terminating?: true} ->
-              Message.send(child_entry.pid, :terminate)
-              child_entry
-
-            %{terminating?: false} when state.playback == :playing ->
-              Message.send(child_entry.pid, :play)
-              %{child_entry | playback: :playing}
-
-            %{terminating?: false} ->
-              child_entry
-          end
-          |> Map.put(:ready?, true)
+        cond do
+          terminating? -> Message.send(pid, :terminate)
+          state.playback == :playing -> Message.send(pid, :play)
+          true -> :ok
+        end
 
-        put_in(state, [:children, child], child_entry)
+        put_in(state.children[child].ready?, true)
       end)
 
     state =

lib/membrane/core/parent/lifecycle_controller.ex

@@ -45,7 +45,7 @@ defmodule Membrane.Core.Parent.LifecycleController do
 
     {pinged_children, state} =
       Enum.flat_map_reduce(state.children, state, fn
-        {child, %{ready?: true, terminating?: false, playback: :stopped, pid: pid}}, state ->
+        {child, %{ready?: true, terminating?: false, pid: pid}}, state ->
           Message.send(pid, :play)
           state = put_in(state, [:children, child, :playback], :playing)
           {[child], state}