Merge remote-tracking branch 'origin/master' into handle_spec_playing

Author: FelonEkonom

.github/actions/add_pr_to_smackore_board/action.yml

@@ -1,5 +1,5 @@
 name: 'Add PR to Smackore board, if author is from community'
-description: '(disabled due to github-side bug) Adds PR to "New issues by community" column in Smackore project board, if PR author is from outside Membrane Team.'
+description: 'Adds PR to "New issues by community" column in Smackore project board, if PR author is from outside Membrane Team.'
 inputs:
   GITHUB_TOKEN:
     description: 'GitHub token'
@@ -19,23 +19,23 @@ runs:
         repository: membraneframework/membrane_core
     - name: Maybe add PR to board and set ticket status
       run: | 
-          # currently this causes github action crash, more info here: https://github.com/membraneframework/membrane_core/issues/749
-
-          # export PROJECT_NUMBER=19
-          # export PROJECT_ID=PVT_kwDOAYE_z84AWEIB
-          # export STATUS_FIELD_ID=PVTSSF_lADOAYE_z84AWEIBzgOGd1k
-          # export TARGET_COLUMN_ID=e6b1ee10
+          # currently this may cause github action crash, more info here: https://github.com/membraneframework/membrane_core/issues/749
+          
+          export PROJECT_NUMBER=19
+          export PROJECT_ID=PVT_kwDOAYE_z84AWEIB
+          export STATUS_FIELD_ID=PVTSSF_lADOAYE_z84AWEIBzgOGd1k
+          export TARGET_COLUMN_ID=e6b1ee10
           
-          # export AUTHOR_ORIGIN=$(gh api -H "Accept: application/vnd.github+json" -H "X-GitHub-Api-Version: 2022-11-28" /orgs/membraneframework/teams/membraneteam/members | python scripts/python/get_author_origin.py $AUTHOR_LOGIN)
+          export AUTHOR_ORIGIN=$(gh api -H "Accept: application/vnd.github+json" -H "X-GitHub-Api-Version: 2022-11-28" /orgs/membraneframework/teams/membraneteam/members | python scripts/python/get_author_origin.py $AUTHOR_LOGIN)
 
-          # if [ "$AUTHOR_ORIGIN" == "COMMUNITY" ]
-          # then
-          #   gh pr edit "$PR_URL" --add-project Smackore
-          #   sleep 10
+          if [ "$AUTHOR_ORIGIN" == "COMMUNITY" ]
+          then
+            gh pr edit "$PR_URL" --add-project Smackore
+            sleep 10
 
-          #   export TICKET_ID=$(gh project item-list $PROJECT_NUMBER --owner membraneframework --format json --limit 10000000 | python scripts/python/get_ticket_id.py "$PR_URL")
-          #   gh project item-edit --id $TICKET_ID --field-id $STATUS_FIELD_ID --project-id $PROJECT_ID --single-select-option-id $TARGET_COLUMN_ID
-          # fi
+            export TICKET_ID=$(gh project item-list $PROJECT_NUMBER --owner membraneframework --format json --limit 10000000 | python scripts/python/get_ticket_id.py "$PR_URL")
+            gh project item-edit --id $TICKET_ID --field-id $STATUS_FIELD_ID --project-id $PROJECT_ID --single-select-option-id $TARGET_COLUMN_ID
+          fi
 
       env:
         GH_TOKEN: ${{ inputs.GITHUB_TOKEN }}

lib/membrane/core/callback_handler.ex

@@ -185,6 +185,8 @@ defmodule Membrane.Core.CallbackHandler do
           Error handling actions returned by callback #{inspect(state.module)}.#{callback}
           """)
 
+          log_debug_orginal_error(actions, e, __STACKTRACE__)
+
           reraise e, __STACKTRACE__
       end
 
@@ -198,10 +200,29 @@ defmodule Membrane.Core.CallbackHandler do
             Error handling action #{inspect(action)} returned by callback #{inspect(state.module)}.#{callback}
             """)
 
+            log_debug_orginal_error(action, e, __STACKTRACE__)
+
             reraise e, __STACKTRACE__
         end
       end)
 
     handler_module.handle_end_of_actions(state)
   end
+
+  # We log it, because sometimes, for some reason, crashing process doesn't cause
+  # printing error logs on stderr, so this debug log allows us to get some info
+  # about what happened in case of process crash
+  defp log_debug_orginal_error(action_or_actions, error, stacktrace) do
+    action_or_actions =
+      if(is_list(action_or_actions), do: "actions ", else: "action ") <>
+        inspect(action_or_actions, limit: :infinity)
+
+    Membrane.Logger.debug("""
+    Error while handling #{action_or_actions}
+
+    Orginal error:
+    #{inspect(error, pretty: true, limit: :infinity)}
+    #{Exception.format_stacktrace(stacktrace)}
+    """)
+  end
 end

lib/membrane/core/parent/child_life_controller/crash_group_utils.ex

@@ -16,8 +16,7 @@ defmodule Membrane.Core.Parent.ChildLifeController.CrashGroupUtils do
   def add_crash_group(group_name, mode, children, state)
       when not is_map_key(state.crash_groups, group_name) do
     put_in(
-      state,
-      [:crash_groups, group_name],
+      state.crash_groups[group_name],
       %CrashGroup{
         name: group_name,
         mode: mode,
@@ -28,7 +27,7 @@ defmodule Membrane.Core.Parent.ChildLifeController.CrashGroupUtils do
 
   @spec extend_crash_group(Child.group(), [Child.name()], Parent.state()) :: Parent.state()
   def extend_crash_group(group_name, children, state) do
-    update_in(state, [:crash_groups, group_name, :members], &(children ++ &1))
+    update_in(state.crash_groups[group_name].members, &(children ++ &1))
   end
 
   @spec get_child_crash_group(Child.name(), Parent.state()) :: {:ok, CrashGroup.t()} | :error
@@ -44,7 +43,7 @@ defmodule Membrane.Core.Parent.ChildLifeController.CrashGroupUtils do
     # and we will not want to have it in :crash_group_members in the callback context in handle_crash_group_down/3,
     # so this child is removed from :members in crash group struct
     members = List.delete(group.members, child_name)
-    state = put_in(state, [:crash_groups, group.name, :members], members)
+    state = put_in(state.crash_groups[group.name].members, members)
 
     if group.detonating? and Enum.all?(members, &(not Map.has_key?(state.children, &1))) do
       cleanup_crash_group(group.name, state)
@@ -83,8 +82,7 @@ defmodule Membrane.Core.Parent.ChildLifeController.CrashGroupUtils do
     end)
 
     update_in(
-      state,
-      [:crash_groups, group.name],
+      state.crash_groups[group.name],
       &%CrashGroup{
         &1
         | detonating?: true,
@@ -96,15 +94,15 @@ defmodule Membrane.Core.Parent.ChildLifeController.CrashGroupUtils do
 
   defp cleanup_crash_group(group_name, state) do
     state = exec_handle_crash_group_down(group_name, state)
-    {_group, state} = pop_in(state, [:crash_groups, group_name])
+    {_group, state} = pop_in(state.crash_groups[group_name])
     state
   end
 
   defp exec_handle_crash_group_down(
          group_name,
          state
        ) do
-    crash_group = get_in(state, [:crash_groups, group_name])
+    crash_group = state.crash_groups[group_name]
 
     context_generator =
       &Component.context_from_state(&1,

lib/membrane/element/with_input_pads.ex

@@ -32,7 +32,7 @@ defmodule Membrane.Element.WithInputPads do
                  | Membrane.Element.Action.forward()
                ], Element.state()}
   @doc """
-  Callback invoked when element receives `Membrane.Event.StartOfStream` event.
+  Callback invoked when element receives the first buffer from the specific pad, before `c:#{__MODULE__}.handle_buffer/4`. 
   """
   @callback handle_start_of_stream(
               pad :: Pad.ref(),

scripts/python/get_author_origin.py

@@ -15,6 +15,6 @@
 
   print("COMMUNITY")
 except:
-    print("An exception occurred, provided JSON:")
-    print(membrane_team)
-    print("provided PR_AUTHOR:", pr_author)
+    print("An exception occurred in get_author_origin.py, provided JSON: ", membrane_team)
+    print("Provided PR_AUTHOR: ", pr_author)
+    sys.exit(1)

scripts/python/get_ticket_id.py

@@ -3,11 +3,18 @@
 full_json = json.load(sys.stdin)
 pr_url = sys.argv[1]
 
-try:
-    project_items = full_json["items"]
-    [id] = [item["id"] for item in project_items if ("url" in item["content"] and item["content"]["url"] == pr_url)]
-    print(id)
-except:
-    print("An exception occurred, provided JSON:")
-    print(full_json)
-    print("provided PR_URL:", pr_url)
+project_items = full_json["items"]
+
+item_id = None
+for item in project_items:
+    if "content" in item and "url" in item["content"]:
+        if item["content"]["url"] == pr_url:
+            item_id = item["id"]
+            break
+
+if item_id == None:
+    print("Error occurred in get_ticket.py: ID of ticket related to PR", pr_url, "not found in the provided JSON")
+    print("Provided JSON:", full_json)
+    sys.exit(1)
+else:
+    print(item_id)