Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Bin/Element/Pipeline State field setup_incomplete? to setup_completed? #937

Open
wende opened this issue Jan 30, 2025 · 4 comments
Open

Comments

@wende
Copy link
Contributor

wende commented Jan 30, 2025

@FelonEkonom
Copy link
Member

@mat-hek I guess it should be done before v1.2.0, am I right?

@mat-hek
Copy link
Member

mat-hek commented Feb 19, 2025

It's an internal thing, so I think it doesn't matter. If we want to make it public, it can be as well in 1.2.1

@FelonEkonom
Copy link
Member

It has been added to CallbackContexts in PR with telemetry, so it is a part of public API now and we can still change the name of it until v1.2.0, at least in callback contexts

@FelonEkonom FelonEkonom changed the title Change Bin/Element/Pipeline State .incomplete? to .completed? Change Bin/Element/Pipeline State field setup_incomplete? to setup_completed? Feb 20, 2025
@mat-hek
Copy link
Member

mat-hek commented Feb 21, 2025

Then yes, we need to change it before the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants