Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Bundlex Compilation VSCode Toolchain Issue #942

Closed
druyang opened this issue Feb 20, 2025 · 2 comments
Closed

Windows Bundlex Compilation VSCode Toolchain Issue #942

druyang opened this issue Feb 20, 2025 · 2 comments

Comments

@druyang
Copy link

druyang commented Feb 20, 2025

I ran into this issue when installing on Windows w/ Elixir 1.17.2:

The following arguments were given to IO.chardata_to_string/1:

    # 1
    false

Attempted function clauses (showing 2 out of 2):

    def chardata_to_string(string) when is_binary(string)
    def chardata_to_string(list) when is_list(list)

(elixir 1.17.2) IO.chardata_to_string/1
(elixir 1.17.2) lib/file.ex:246: File.exists?/2
(bundlex 1.5.4) lib/bundlex/toolchain/visual_studio.ex:102: Bundlex.Toolchain.VisualStudio.run_vcvarsall/1
(bundlex 1.5.4) lib/bundlex/toolchain/visual_studio.ex:26: Bundlex.Toolchain.VisualStudio.before_all!/1`

It seems like directory_root is evaluating to :false here:

program_files = System.fetch_env!("ProgramFiles(x86)") |> Path.expand()
directory_root = Path.join([program_files, "Microsoft Visual Studio"])
@mat-hek
Copy link
Member

mat-hek commented Feb 21, 2025

I think the problem is here: https://github.com/membraneframework/bundlex/blob/8f3b94a8d643c4513d61355be53136cb2ea8fbb4/lib/bundlex/toolchain/visual_studio.ex#L117
there's no proper error thrown, but it seems that the original issue is vswhere.exe missing

@druyang
Copy link
Author

druyang commented Feb 21, 2025

I think you're right. I'm new to Elixir, I opened a PR to help provide a warning to the user for that original issue:

membraneframework/bundlex#136

@druyang druyang closed this as completed Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants