Livebooks 1.0 #267
Livebooks 1.0 #267
Conversation
livebooks/README.md
Outdated
| # Livebook examples | ||
|
|
||
| This folder contains interactive livebook examples. To launch them you need to install livebook first. | ||
|
|
||
| ## Installation | ||
|
|
||
| 1. Install Livebook | ||
|
|
||
| It is recommended to install Livebook via command line ([see official installation guide](https://github.com/livebook-dev/livebook#escript)). | ||
|
|
||
| If livebook was installed directly from the official page, one should add `$PATH` variable to the Livebook environment: | ||
|  |
There was a problem hiding this comment.
Was this in guide? 1. in line 7 looks little bit weird
| pipeline = RC.Pipeline.start!() | ||
| RC.Pipeline.exec_actions(pipeline, spec: structure, playback: :playing) | ||
| pipeline = RC.start!() | ||
| RC.exec_actions(pipeline, spec: structure) |
There was a problem hiding this comment.
| RC.exec_actions(pipeline, spec: structure) | |
| RC.exec_actions(pipeline, spec: spec) |
| def_output_pad(:output, | ||
| mode: :push, | ||
| flow_control: :push, | ||
| accepted_format: _any | ||
| ) | ||
|
|
There was a problem hiding this comment.
Remove the brackets from all pad definitions
There was a problem hiding this comment.
I did it, but Livebook does some kind of auto-formatting and adds these brackets every time you just open the file in Livebook.
livebooks/rtmp/rtmp_receiver.livemd
Outdated
| }) | ||
| |> via_in(:video) | ||
| |> get_child(:player) | ||
|
|
||
| player = child(:player, %Membrane.Kino.Player.Sink{kino: kino}) | ||
|
|
||
| structure = [source, playing_audio, playing_video, player] | ||
| {[spec: structure, playback: :playing], %{}} | ||
| {[spec: structure], %{}} |
There was a problem hiding this comment.
| {[spec: structure], %{}} | |
| {[spec: spec], %{}} |
You can rename structure to spec in similar places as well
|
|
||
| audio_source = | ||
| child(:audio_source, %Membrane.Hackney.Source{ | ||
| location: @audio_url, | ||
| hackney_opts: [follow_redirect: true] | ||
| }) | ||
| |> child(:audio_parser, %Membrane.AAC.Parser{ | ||
| in_encapsulation: :ADTS, |
There was a problem hiding this comment.
I am not a specialist, when it comes to AAC, but make sure, that it is safe, to remove this option
There was a problem hiding this comment.
In current version of acc parser this field no longer exists. Documentation says, correct acc stream format is supplied with the stream. And it works just fine
solves: membraneframework/membrane_core#704