Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMAF demuxer #118

Merged
merged 41 commits into from
Jan 20, 2025
Merged

CMAF demuxer #118

merged 41 commits into from
Jan 20, 2025

Conversation

varsill
Copy link
Contributor

@varsill varsill commented Jan 2, 2025 •
edited
Loading

TODO:

  • Add more tests and tests fixtures
  • Return buffers as soon as mdat header is read - we decided not to do it, as mdat boxes are expected to be small enough
  • Find common parts of code with ISOM demuxer and maybe unify them

@varsill varsill linked an issue Jan 3, 2025 that may be closed by this pull request
CMAF Demuxer in MP4 membraneframework/membrane_core#930
Closed
@varsill varsill force-pushed the varsill/cmaf_demuxer branch from 52f7610 to da6df99 Compare January 7, 2025 10:05
@varsill varsill marked this pull request as ready for review January 7, 2025 15:13
@varsill varsill requested a review from mat-hek as a code owner January 7, 2025 15:13
@varsill varsill changed the base branch from master to fix-sample-sizes January 8, 2025 15:33
mat-hek
mat-hek approved these changes Jan 9, 2025
View reviewed changes
Base automatically changed from fix-sample-sizes to master January 13, 2025 09:02
@varsill varsill requested a review from mat-hek January 13, 2025 15:13
mat-hek
mat-hek reviewed Jan 20, 2025
View reviewed changes
lib/membrane_mp4/demuxer/cmaf/samples_info.ex Outdated
Comment on lines 55 to 58
Enum.filter(traf_box.children, fn {box_name, _box} -> box_name == :trun end)
|> Enum.flat_map_reduce(base_media_decode_time, fn {:trun, trun_box}, ts_acc ->
{samples, {_size_acc, ts_acc}} =
Enum.map_reduce(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make this a bit more readable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried, you can take a look ;)

@varsill varsill requested a review from mat-hek January 20, 2025 15:27
@varsill varsill merged commit 66e163f into master Jan 20, 2025
3 checks passed
@varsill varsill deleted the varsill/cmaf_demuxer branch January 20, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mat-hek mat-hek Awaiting requested review from mat-hek mat-hek is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMAF Demuxer in MP4
2 participants
@varsill @mat-hek