From 0d43bc24021d5423732696aacb1d2f1405fdc973 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Kita?= Date: Mon, 19 Feb 2024 10:27:10 +0100 Subject: [PATCH 1/3] Make sure try_connect/1 is scheduled on a dirty scheduler. Fix a dirty scheduler configuration for write_video_frame/5 --- README.md | 2 +- c_src/membrane_rtmp_plugin/sink/rtmp_sink.spec.exs | 2 +- mix.exs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 6acb7288..9ddfb17d 100644 --- a/README.md +++ b/README.md @@ -14,7 +14,7 @@ The package can be installed by adding `membrane_rtmp_plugin` to your list of de ```elixir def deps do [ - {:membrane_rtmp_plugin, "~> 0.22.0"} + {:membrane_rtmp_plugin, "~> 0.22.1"} ] end ``` diff --git a/c_src/membrane_rtmp_plugin/sink/rtmp_sink.spec.exs b/c_src/membrane_rtmp_plugin/sink/rtmp_sink.spec.exs index 30216f81..720444b7 100644 --- a/c_src/membrane_rtmp_plugin/sink/rtmp_sink.spec.exs +++ b/c_src/membrane_rtmp_plugin/sink/rtmp_sink.spec.exs @@ -27,4 +27,4 @@ spec init_audio_stream(state, channels :: int, sample_rate :: int, aac_config :: spec write_audio_frame(state, frame :: payload, pts :: int64) :: {:ok :: label, state} | {:error :: label, reason :: string} -dirty :io, write_video_frame: 4, write_audio_frame: 3 +dirty :io, write_video_frame: 5, write_audio_frame: 3, try_connect: 1 diff --git a/mix.exs b/mix.exs index b3045736..29051a99 100644 --- a/mix.exs +++ b/mix.exs @@ -1,7 +1,7 @@ defmodule Membrane.RTMP.Mixfile do use Mix.Project - @version "0.22.0" + @version "0.22.1" @github_url "https://github.com/membraneframework/membrane_rtmp_plugin" def project do From d45094210726b50f949662d04caa4addb5e2b786 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Kita?= Date: Mon, 19 Feb 2024 14:57:49 +0100 Subject: [PATCH 2/3] Implement `validate_on_expect_additional_media` for the TestValidator to fix a CI failure --- test/support/test_validator.ex | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/support/test_validator.ex b/test/support/test_validator.ex index 669a2aa6..3bcc7e05 100644 --- a/test/support/test_validator.ex +++ b/test/support/test_validator.ex @@ -35,4 +35,7 @@ defimpl Membrane.RTMP.MessageValidator, for: Support.TestValidator do @impl true def validate_on_meta_data(_impl, _message), do: {:ok, "on meta data success"} + + @impl true + def validate_on_expect_additional_media(_impl, _message), do: {:ok, "on expect additional media success"} end From 04126b2a8a8529f944ea53ac93d005100943425b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Kita?= Date: Mon, 19 Feb 2024 15:00:32 +0100 Subject: [PATCH 3/3] Perform formatting --- test/support/test_validator.ex | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/support/test_validator.ex b/test/support/test_validator.ex index 3bcc7e05..4526ca12 100644 --- a/test/support/test_validator.ex +++ b/test/support/test_validator.ex @@ -37,5 +37,6 @@ defimpl Membrane.RTMP.MessageValidator, for: Support.TestValidator do def validate_on_meta_data(_impl, _message), do: {:ok, "on meta data success"} @impl true - def validate_on_expect_additional_media(_impl, _message), do: {:ok, "on expect additional media success"} + def validate_on_expect_additional_media(_impl, _message), + do: {:ok, "on expect additional media success"} end