Handle socket closed by client before start of stream arrives in RTMP Source Bin #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qizot
reviewed
Feb 28, 2024
Qizot
approved these changes
Feb 28, 2024
|
@Qizot sure, it is no problem, however, I'm not sure the patch version is the correct one to bump. Since now a new message is being sent to the parent pipeline if it is not explicitly handled it can crash the pipeline. What do you think? |
|
@nickdichev-firework you're right. Bump the minor then :) |
|
@Qizot I've sent a commit to bump the version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a flow in my application where the client was closing the socket before the start of stream was being sent. That was causing the RTMP source to send a message
:unexpected_socket_closedto the parent, which in my case is the RTMP Source Bin. https://github.com/membraneframework/membrane_rtmp_plugin/blob/v0.22.1/lib/membrane_rtmp_plugin/rtmp/source/source.ex#L228This message is not being handled by the bin so it causes a crash in my application. I have added handling for this case and decided to send the message to the bin's parent.