SourceBin dynamic pads

README.md

@@ -14,7 +14,7 @@ The package can be installed by adding `membrane_rtmp_plugin` to your list of de
 ```elixir
 def deps do
   [
-	  {:membrane_rtmp_plugin, "~> 0.23.5"}
+	  {:membrane_rtmp_plugin, "~> 0.25.0"}
   ]
 end
 ```

lib/membrane_rtmp_plugin/rtmp/source/source_bin.ex

@@ -42,13 +42,12 @@ defmodule Membrane.RTMP.SourceBin do
 
   @impl true
   def handle_init(_ctx, %__MODULE__{} = opts) do
-    spec = [
+    spec =
       child(:src, %RTMP.Source{
         client_ref: opts.client_ref,
         url: opts.url
       })
       |> child(:demuxer, Membrane.FLV.Demuxer)
-    ]
 
     state = %{
       demuxer_audio_pad_ref: nil,
@@ -59,81 +58,37 @@ defmodule Membrane.RTMP.SourceBin do
   end
 
   @impl true
-  def handle_pad_added(Pad.ref(:audio, _ref) = pad, _ctx, state) do
+  def handle_pad_added(Pad.ref(:audio, _ref) = pad, ctx, state) do
+    assert_pad_count!(:audio, ctx)
+
     spec =
-      if state.demuxer_audio_pad_ref != nil do
-        [
-          get_child(:demuxer)
-          |> via_out(state.demuxer_audio_pad_ref)
-          |> child(:audio_parser, %Membrane.AAC.Parser{
-            out_encapsulation: :none
-          })
-          |> bin_output(pad)
-        ]
-      else
-        [
-          child(:funnel_audio, Membrane.Funnel)
-          |> bin_output(pad)
-        ]
-      end
+      child(:funnel_audio, Membrane.Funnel, get_if_exists: true)
+      |> bin_output(pad)
 
-    {[spec: spec], state}
+    {actions, state} = maybe_link_audio_pad(state)
+
+    {[spec: spec] ++ actions, state}
   end
 
-  def handle_pad_added(Pad.ref(:video, _ref) = pad, _ctx, state) do
+  def handle_pad_added(Pad.ref(:video, _ref) = pad, ctx, state) do
+    assert_pad_count!(:video, ctx)
+
     spec =
-      if state.demuxer_video_pad_ref != nil do
-        [
-          get_child(:demuxer)
-          |> via_out(state.demuxer_video_pad_ref)
-          |> child(:video_parser, Membrane.H264.Parser)
-          |> bin_output(pad)
-        ]
-      else
-        [
-          child(:funnel_video, Membrane.Funnel)
-          |> bin_output(pad)
-        ]
-      end
+      child(:funnel_video, Membrane.Funnel, get_if_exists: true)
+      |> bin_output(pad)
 
-    {[spec: spec], state}
+    {actions, state} = maybe_link_video_pad(state)
+
+    {[spec: spec] ++ actions, state}
   end
 
   @impl true
-  def handle_child_notification({:new_stream, pad_ref, :AAC}, :demuxer, ctx, state) do
-    audio_pad_ref = get_pad(:audio, ctx)
-
-    if audio_pad_ref != nil do
-      {[
-         spec: [
-           get_child(:demuxer)
-           |> via_out(pad_ref)
-           |> child(:audio_parser, %Membrane.AAC.Parser{
-             out_encapsulation: :none
-           })
-           |> get_child(:funnel_audio)
-         ]
-       ], state}
-    else
-      {[], %{state | demuxer_audio_pad_ref: pad_ref}}
-    end
+  def handle_child_notification({:new_stream, pad_ref, :AAC}, :demuxer, _ctx, state) do
+    maybe_link_audio_pad(%{state | demuxer_audio_pad_ref: pad_ref})
   end
 
-  def handle_child_notification({:new_stream, pad_ref, :H264}, :demuxer, ctx, state) do
-    video_pad_ref = get_pad(:video, ctx)
-
-    if video_pad_ref != nil do
-      {[
-         spec: [
-           get_child(:demuxer)
-           |> via_out(pad_ref)
-           |> child(:video_parser, Membrane.H264.Parser)
-           |> get_child(:funnel_video)
-         ]
-       ], state}
-    else
-      {[], %{state | demuxer_video_pad_ref: pad_ref}}
-    end
+  def handle_child_notification({:new_stream, pad_ref, :H264}, :demuxer, _ctx, state) do
+    maybe_link_video_pad(%{state | demuxer_video_pad_ref: pad_ref})
   end
 
   def handle_child_notification(
@@ -180,9 +135,46 @@ defmodule Membrane.RTMP.SourceBin do
     :ssl.controlling_process(socket, source)
   end
 
-  defp get_pad(name, ctx) do
-    ctx.pads
-    |> Map.keys()
-    |> Enum.find(fn pad_ref -> Pad.name_by_ref(pad_ref) == name end)
+  defp maybe_link_audio_pad(state) when state.demuxer_audio_pad_ref != nil do
+    {[
+       spec:
+         get_child(:demuxer)
+         |> via_out(state.demuxer_audio_pad_ref)
+         |> child(:audio_parser, %Membrane.AAC.Parser{
+           out_encapsulation: :none
+         })
+         |> child(:funnel_audio, Membrane.Funnel, get_if_exists: true)
+     ], state}
+  end
+
+  defp maybe_link_audio_pad(state) do
+    {[], state}
+  end
+
+  defp maybe_link_video_pad(state) when state.demuxer_video_pad_ref != nil do
+    {[
+       spec:
+         get_child(:demuxer)
+         |> via_out(state.demuxer_video_pad_ref)
+         |> child(:video_parser, Membrane.H264.Parser)
+         |> child(:funnel_video, Membrane.Funnel, get_if_exists: true)
+     ], state}
+  end
+
+  defp maybe_link_video_pad(state) do
+    {[], state}
+  end
+
+  defp assert_pad_count!(name, ctx) do
+    count =
+      ctx.pads
+      |> Map.keys()
+      |> Enum.count(fn pad_ref -> Pad.name_by_ref(pad_ref) == name end)
+
+    if count > 1 do
+      raise("Linking more than one #{name} output pad to #{inspect(__MODULE__)} is not allowed")
+    end
+
+    :ok
   end
 end

mix.exs

@@ -1,7 +1,7 @@
 defmodule Membrane.RTMP.Mixfile do
   use Mix.Project
 
-  @version "0.23.5"
+  @version "0.25.0"
   @github_url "https://github.com/membraneframework/membrane_rtmp_plugin"
 
   def project do

mix.lock

@@ -14,7 +14,7 @@
   "erlex": {:hex, :erlex, "0.2.7", "810e8725f96ab74d17aac676e748627a07bc87eb950d2b83acd29dc047a30595", [:mix], [], "hexpm", "3ed95f79d1a844c3f6bf0cea61e0d5612a42ce56da9c03f01df538685365efb0"},
   "ex_doc": {:hex, :ex_doc, "0.34.2", "13eedf3844ccdce25cfd837b99bea9ad92c4e511233199440488d217c92571e8", [:mix], [{:earmark_parser, "~> 1.4.39", [hex: :earmark_parser, repo: "hexpm", optional: false]}, {:makeup_c, ">= 0.1.0", [hex: :makeup_c, repo: "hexpm", optional: true]}, {:makeup_elixir, "~> 0.14 or ~> 1.0", [hex: :makeup_elixir, repo: "hexpm", optional: false]}, {:makeup_erlang, "~> 0.1 or ~> 1.0", [hex: :makeup_erlang, repo: "hexpm", optional: false]}, {:makeup_html, ">= 0.1.0", [hex: :makeup_html, repo: "hexpm", optional: true]}], "hexpm", "5ce5f16b41208a50106afed3de6a2ed34f4acfd65715b82a0b84b49d995f95c1"},
   "ffmpex": {:hex, :ffmpex, "0.10.0", "ce29281eac60bf109c05acb4342eecf813a3cd3f08c1bce350423caad86128af", [:mix], [{:jason, "~> 1.2", [hex: :jason, repo: "hexpm", optional: false]}, {:rambo, "~> 0.3.0", [hex: :rambo, repo: "hexpm", optional: false]}], "hexpm", "de8d81f8c51cc258dcee9a3e0b1568b0659c97be004557d9af47795206cff53b"},
-  "file_system": {:hex, :file_system, "1.0.0", "b689cc7dcee665f774de94b5a832e578bd7963c8e637ef940cd44327db7de2cd", [:mix], [], "hexpm", "6752092d66aec5a10e662aefeed8ddb9531d79db0bc145bb8c40325ca1d8536d"},
+  "file_system": {:hex, :file_system, "1.0.1", "79e8ceaddb0416f8b8cd02a0127bdbababe7bf4a23d2a395b983c1f8b3f73edd", [:mix], [], "hexpm", "4414d1f38863ddf9120720cd976fce5bdde8e91d8283353f0e31850fa89feb9e"},
   "finch": {:hex, :finch, "0.18.0", "944ac7d34d0bd2ac8998f79f7a811b21d87d911e77a786bc5810adb75632ada4", [:mix], [{:castore, "~> 0.1 or ~> 1.0", [hex: :castore, repo: "hexpm", optional: false]}, {:mime, "~> 1.0 or ~> 2.0", [hex: :mime, repo: "hexpm", optional: false]}, {:mint, "~> 1.3", [hex: :mint, repo: "hexpm", optional: false]}, {:nimble_options, "~> 0.4 or ~> 1.0", [hex: :nimble_options, repo: "hexpm", optional: false]}, {:nimble_pool, "~> 0.2.6 or ~> 1.0", [hex: :nimble_pool, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "69f5045b042e531e53edc2574f15e25e735b522c37e2ddb766e15b979e03aa65"},
   "hackney": {:hex, :hackney, "1.20.1", "8d97aec62ddddd757d128bfd1df6c5861093419f8f7a4223823537bad5d064e2", [:rebar3], [{:certifi, "~> 2.12.0", [hex: :certifi, repo: "hexpm", optional: false]}, {:idna, "~> 6.1.0", [hex: :idna, repo: "hexpm", optional: false]}, {:metrics, "~> 1.0.0", [hex: :metrics, repo: "hexpm", optional: false]}, {:mimerl, "~> 1.1", [hex: :mimerl, repo: "hexpm", optional: false]}, {:parse_trans, "3.4.1", [hex: :parse_trans, repo: "hexpm", optional: false]}, {:ssl_verify_fun, "~> 1.1.0", [hex: :ssl_verify_fun, repo: "hexpm", optional: false]}, {:unicode_util_compat, "~> 0.7.0", [hex: :unicode_util_compat, repo: "hexpm", optional: false]}], "hexpm", "fe9094e5f1a2a2c0a7d10918fee36bfec0ec2a979994cff8cfe8058cd9af38e3"},
   "hpax": {:hex, :hpax, "1.0.0", "28dcf54509fe2152a3d040e4e3df5b265dcb6cb532029ecbacf4ce52caea3fd2", [:mix], [], "hexpm", "7f1314731d711e2ca5fdc7fd361296593fc2542570b3105595bb0bc6d0fad601"},
@@ -49,7 +49,7 @@
   "qex": {:hex, :qex, "0.5.1", "0d82c0f008551d24fffb99d97f8299afcb8ea9cf99582b770bd004ed5af63fd6", [:mix], [], "hexpm", "935a39fdaf2445834b95951456559e9dc2063d0a055742c558a99987b38d6bab"},
   "rambo": {:hex, :rambo, "0.3.4", "8962ac3bd1a633ee9d0e8b44373c7913e3ce3d875b4151dcd060886092d2dce7", [:mix], [], "hexpm", "0cc54ed089fbbc84b65f4b8a774224ebfe60e5c80186fafc7910b3e379ad58f1"},
   "ratio": {:hex, :ratio, "4.0.1", "3044166f2fc6890aa53d3aef0c336f84b2bebb889dc57d5f95cc540daa1912f8", [:mix], [{:decimal, "~> 1.6 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: true]}, {:numbers, "~> 5.2.0", [hex: :numbers, repo: "hexpm", optional: false]}], "hexpm", "c60cbb3ccdff9ffa56e7d6d1654b5c70d9f90f4d753ab3a43a6bf40855b881ce"},
-  "req": {:hex, :req, "0.5.4", "e375e4812adf83ffcf787871d7a124d873e983e3b77466e6608b973582f7f837", [:mix], [{:brotli, "~> 0.3.1", [hex: :brotli, repo: "hexpm", optional: true]}, {:ezstd, "~> 1.0", [hex: :ezstd, repo: "hexpm", optional: true]}, {:finch, "~> 0.17", [hex: :finch, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}, {:mime, "~> 2.0.6 or ~> 2.1", [hex: :mime, repo: "hexpm", optional: false]}, {:nimble_csv, "~> 1.0", [hex: :nimble_csv, repo: "hexpm", optional: true]}, {:plug, "~> 1.0", [hex: :plug, repo: "hexpm", optional: true]}], "hexpm", "a17998ffe2ef54f79bfdd782ef9f4cbf987d93851e89444cbc466a6a25eee494"},
+  "req": {:hex, :req, "0.5.6", "8fe1eead4a085510fe3d51ad854ca8f20a622aae46e97b302f499dfb84f726ac", [:mix], [{:brotli, "~> 0.3.1", [hex: :brotli, repo: "hexpm", optional: true]}, {:ezstd, "~> 1.0", [hex: :ezstd, repo: "hexpm", optional: true]}, {:finch, "~> 0.17", [hex: :finch, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}, {:mime, "~> 2.0.6 or ~> 2.1", [hex: :mime, repo: "hexpm", optional: false]}, {:nimble_csv, "~> 1.0", [hex: :nimble_csv, repo: "hexpm", optional: true]}, {:plug, "~> 1.0", [hex: :plug, repo: "hexpm", optional: true]}], "hexpm", "cfaa8e720945d46654853de39d368f40362c2641c4b2153c886418914b372185"},
   "shmex": {:hex, :shmex, "0.5.1", "81dd209093416bf6608e66882cb7e676089307448a1afd4fc906c1f7e5b94cf4", [:mix], [{:bunch_native, "~> 0.5.0", [hex: :bunch_native, repo: "hexpm", optional: false]}, {:bundlex, "~> 1.0", [hex: :bundlex, repo: "hexpm", optional: false]}], "hexpm", "c29f8286891252f64c4e1dac40b217d960f7d58def597c4e606ff8fbe71ceb80"},
   "ssl_verify_fun": {:hex, :ssl_verify_fun, "1.1.7", "354c321cf377240c7b8716899e182ce4890c5938111a1296add3ec74cf1715df", [:make, :mix, :rebar3], [], "hexpm", "fe4c190e8f37401d30167c8c405eda19469f34577987c76dde613e838bbc67f8"},
   "telemetry": {:hex, :telemetry, "1.2.1", "68fdfe8d8f05a8428483a97d7aab2f268aaff24b49e0f599faa091f1d4e7f61c", [:rebar3], [], "hexpm", "dad9ce9d8effc621708f99eac538ef1cbe05d6a874dd741de2e689c47feafed5"},